Closed Bug 493695 Opened 11 years ago Closed 11 years ago

create accessibles for HTML tr

Categories

(Core :: Disability Access APIs, defect)

defect
Not set

Tracking

()

VERIFIED FIXED

People

(Reporter: surkov, Assigned: surkov)

References

(Blocks 1 open bug)

Details

(Keywords: access)

Attachments

(1 file, 2 obsolete files)

patch creates generic accessible for HTML tr and do not create accessibles for HTML thead, tbody, tfoot. We need to check how AT works with this.
Assignee: nobody → surkov.alexander
Status: NEW → ASSIGNED
Attached patch patch (obsolete) — Splinter Review
try server build (create accessibles for HTML tr) - https://build.mozilla.org/tryserver-builds/surkov.alexander@gmail.com-1242716596/

try server build (create accessibles for HTML tr, do not create accessibles for thead, tbody, tfoot) - https://build.mozilla.org/tryserver-builds/surkov.alexander@gmail.com-1242716806/
Alex, right now, the accessibles don't get a proper role. They get an unknown role and a role string of "tr".
Attached patch patch2 (obsolete) — Splinter Review
Damn. Thank you, Marco. Could please check this one?
Attachment #378270 - Attachment is obsolete: true
This one works much better! NVDA again sees the table contents, and JAWS seems unaffected by the change.

One question:
Is it wanted that each TR accessible gets the whole row's content as its accessible name? In other words, each cell's content is concatenated to one long string (with spaces) from all the text inside that row.
(In reply to comment #5)

> One question:
> Is it wanted that each TR accessible gets the whole row's content as its
> accessible name? In other words, each cell's content is concatenated to one
> long string (with spaces) from all the text inside that row.

Iirc Rich said previously it shouldn't. It's another issue though.
Attached patch patch3Splinter Review
All screen reader vendors we work with are fine with this change. So create accessilbe for HTML tr, leave alone accessibles for thead and etc for now until we confirm we don't need them.
Attachment #378312 - Attachment is obsolete: true
Attachment #378558 - Flags: review?(marco.zehe)
Attachment #378558 - Flags: review?(david.bolter)
Comment on attachment 378558 [details] [diff] [review]
patch3

r=me thanks!
Has anyone tried with Orca?
Attachment #378558 - Flags: review?(david.bolter) → review+
Attachment #378558 - Flags: review?(marco.zehe) → review+
(In reply to comment #8)
> (From update of attachment 378558 [details] [diff] [review])
> r=me thanks!
> Has anyone tried with Orca?

Afaik not yet, but Joanie said Orca uses table-cell-index object attribute so everything should be fine.
Don't forget to mark bug 400539 worksforme once this one is landed.
http://hg.mozilla.org/mozilla-central/rev/04ed36482fa9
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Verified fixed in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090618 Minefield/3.6a1pre (.NET CLR 3.5.30729)
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.