493697 - Update Findbook.tw Favicon

Status: RESOLVED FIXED

(Mozilla Localizations :: zh-TW / Chinese (Traditional), defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: Search Engine xml

Hi,

Findbook is the search engine we included since fx3.0 (bug 418273); they recently changed their icon so I think we should too.

The change should goes to 1.9.0.x (fx3), 1.9.1 (fx3.5), and l10n-central/mobile/searchengines, which is Fennec search engines that I simply copied them from firefox.

I will attach patch file for review later today.

Tim

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: Patch to change favicon

Comment 2

[Staś Małolepszy :stas]

Comment on attachment 378337 [details] [diff] [review]
Patch to change favicon

Hey Tim. 

r=me, please land it using a descriptive comment mentioning this bug's number and my review.

Please feel free to update the revision used for the RC1 opt in.

Please add the fixed1.9.1 keyword after landing on 1.9.1, and verified1.9.1 after verifying the change in a nightly build.

Asking for approval for landing on 1.9.0.

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Landed on 1.9.1.
http://hg.mozilla.org/releases/l10n-mozilla-1.9.1/zh-TW/rev/afca31ed13ff

Comment 4

[Axel Hecht [:Pike]]

Comment on attachment 378337 [details] [diff] [review]
Patch to change favicon

a=me for 1.9.0.12. Please land with a check-in comment referencing this bug and my approval as well as stas' review. Something like "bug 493697, update findbook.tw icon, r=stas, a=[e-mail]" would do.

Please use the fixed1.9.0.12 and verified1.9.0.12 keyword to track landing and testing.

PS: On 1.9.1 aka hg we're going to use a different scheme. Changes like this still need review from stas, but in general the hg repos are open for check-in. Just poke us on when to update the source stamp to use for the releases. Details will be in .l10n.

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

http://bonsai-l10n.mozilla.org/cvsblame.cgi?file=l10n/zh-TW/browser/searchplugins/findbook-zh-TW.xml&rev=1.3&root=/l10n

committed, fixed and verified on nightly build. Thanks everyone.