493702 - iframes do not print since bug 485275 landed

Status: RESOLVED FIXED

Description

[Timothy Nikkel (:tnikkel)]

Attachment: patch

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

This clearly blocks.

I wish we could write a test for this but I suspect we currently can't due to the way printing iframes works ("badly").

Comment 2

[Timothy Nikkel (:tnikkel)]

Attachment: 1.9.1 patch

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

actually a reftest-print reftest with iframes probably would just work...

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

http://hg.mozilla.org/mozilla-central/rev/409416c625bc

Comment 5

[Timothy Nikkel (:tnikkel)]

(In reply to comment #3)
> actually a reftest-print reftest with iframes probably would just work...

Apparently not. I tried using a page with an image as the ref, and the test was just an iframe of the ref. This worked fine when manually print-previewing them. But when running them as reftests the test would not draw the the image by the time the reftest harness took the snapshot (the iframe border at least was getting drawn when I allowed it to have a border). I tried doing some hacky things combining reftest-print and reftest-wait and removing the reftest-wait part when the iframe document had loaded, but I couldn't get it to work. Not surprising given the reftest readme:

"The underlying layout support for this mode isn't really complete; it doesn't use exactly the same codepath as real print preview/print. In particular, scripting and frames are likely to cause problems;"

Perhaps a test of print previewing a page with an iframe could be added to the basic functionality tests that are performed for releases.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/f56f757847b9

Thanks Timothy!!