Closed Bug 493702 Opened 12 years ago Closed 12 years ago

iframes do not print since bug 485275 landed

Categories

(Core :: Layout: Images, Video, and HTML Frames, defect)

1.9.1 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: tnikkel, Assigned: tnikkel)

References

Details

(Keywords: fixed1.9.1)

Attachments

(2 files)

Attached patch patchSplinter Review
No description provided.
Flags: blocking1.9.1?
Attachment #378279 - Flags: review?(roc)
Attachment #378279 - Flags: approval1.9.1?
Assignee: nobody → tnikkel
Attachment #378279 - Flags: review?(roc)
Attachment #378279 - Flags: review+
Attachment #378279 - Flags: approval1.9.1?
Attachment #378279 - Flags: approval1.9.1+
This clearly blocks.

I wish we could write a test for this but I suspect we currently can't due to the way printing iframes works ("badly").
Flags: blocking1.9.1? → blocking1.9.1+
Keywords: checkin-needed
Whiteboard: [needs landing]
Attached patch 1.9.1 patchSplinter Review
Attachment #378288 - Flags: review+
actually a reftest-print reftest with iframes probably would just work...
http://hg.mozilla.org/mozilla-central/rev/409416c625bc
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: in-testsuite?
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [needs landing] → [needs 191 landing]
Keywords: checkin-needed
(In reply to comment #3)
> actually a reftest-print reftest with iframes probably would just work...

Apparently not. I tried using a page with an image as the ref, and the test was just an iframe of the ref. This worked fine when manually print-previewing them. But when running them as reftests the test would not draw the the image by the time the reftest harness took the snapshot (the iframe border at least was getting drawn when I allowed it to have a border). I tried doing some hacky things combining reftest-print and reftest-wait and removing the reftest-wait part when the iframe document had loaded, but I couldn't get it to work. Not surprising given the reftest readme:

"The underlying layout support for this mode isn't really complete; it doesn't use exactly the same codepath as real print preview/print. In particular, scripting and frames are likely to cause problems;"

Perhaps a test of print previewing a page with an iframe could be added to the basic functionality tests that are performed for releases.
Product: Core → Core Graveyard
Component: Layout: HTML Frames → Layout: Images
Product: Core Graveyard → Core
You need to log in before you can comment on or make changes to this bug.