493719 - The inline "Edit Contact" dialog shows a vertical line

Status: RESOLVED FIXED

(Thunderbird :: Message Reader UI, defect)

Description

[Alex Ihrig [:Thunderbird_Mail_DE]]

In latest nightly win32 Thunderbird builds the inline "Edit Contact" dialog still shows a vertical line in the background. This line is intended to differ the left icons from text in normal menus. But here we have an inline dialog poping up, when the yellow star icon is clicked.

The screenshots from Linux / OS X in Bug 450724 don't show this line. So it's maybe only a Windows skin problem.

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

Can I talk you into adding a screenshot?  That would make it easier to triage this bug...

Comment 2

[Alex Ihrig [:Thunderbird_Mail_DE]]

Attachment: Edit Contact screenshot with vertical line

The screenshot shows the vertical line behind the yellow star.

Comment 3

[Mark Banner (:standard8)]

Does an equivalent Firefox build show a line behind its yellow star on the edit bookmark option at the end of the url bar?

Comment 4

[Alex Ihrig [:Thunderbird_Mail_DE]]

Attachment: Inline Edit Bookmark dialog

Firefox' inline Edit Bookmark dialog doesn't show the vertical line. Tested with 3.0.10 and 3.5b5pre (screenshot).

Comment 5

[Dan Mosedale (:dmosedale, :dmose)]

Any chance this is intentional?  Adding Andreas and Bryan for their thoughts...

Comment 6

[Phil Ringnalda (:philor)]

Depends on whose intention you're talking about: in Qute and Gnomestripe, the panel has -moz-appearance: menupopup, and the intention of the Windows theme folks was that on Vista/Win7, a menupopup's appearance would be "have an ugly embossed line running down the left side, to set off icons and checkmarks."

Comment 7

[Phil Ringnalda (:philor)]

See bug 413060 comment 10 et seq. and http://mxr.mozilla.org/mozilla-central/source/browser/themes/winstripe/browser/browser-aero.css#38 - basically, because menupopup looks good for everything except Aero, you want -moz-appearance: menupopup, overridden by -moz-appearance: tooltip for just Aero.

Comment 8

[Bryan Clark (DevTools PM) [:clarkbw]]

hmm, that won't likely be possible until bug 468751 gets done so we have a separate aero theme space

Comment 9

[Dan Mosedale (:dmosedale, :dmose)]

I've been trying to poke at bug 468751, but have had some issues; will comment there.

Comment 10

[Bryan Clark (DevTools PM) [:clarkbw]]

Attachment: vista edit contacts screenshot

I keep looking back at this but I'm waiting on bug 494430 to finish creating the separate aero css file.  Here's the patch to mailWindow1-aero.css that gets this going.

+
+/* Bug 493719, comment 7:  menupopup looks good for everything except Aero,
+   you want -moz-appearance: menupopup, overridden by -moz-appearance: tooltip
+   for just Aero. */
+#editContactPanel:-moz-system-metric(windows-default-theme) {
+  -moz-appearance: tooltip;
+  color: InfoText;
+}

Comment 11

[Alex Ihrig [:Thunderbird_Mail_DE]]

AFAIK we now have a separate Aero theme, but Bug 468751 is not marked as resolved fixed.

Comment 12

[Alex Ihrig [:Thunderbird_Mail_DE]]

(In reply to comment #11)
> AFAIK we now have a separate Aero theme, but Bug 468751 is not marked as
> resolved fixed.

Ah, I meant bug 494430 isn't fixed.

Comment 13

[Phil Ringnalda (:philor)]

Attachment: Fix

Comment 14

[Alex Ihrig [:Thunderbird_Mail_DE]]

The fix is working for me.

Comment 15

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/comm-central/rev/e4fe0e35501d