493729 - URL text box in the exception dialog should always be LTR

Status: RESOLVED FIXED

(Core Graveyard :: Security: UI, defect)

Description

[(no longer active)]

Attachment: Patch (v1)

URL text box in the exception dialog should always be LTR, even in RTL locales.

Comment 1

[Johnathan Nightingale [:johnath]]

Comment on attachment 378317 [details] [diff] [review]
Patch (v1)

This code change looks fine, but can you help me understand why it is that URL fields don't want RTL?  Is that just a universal rule? I'm very sad to say that I speak/read no RTL languages.

Comment 2

[(no longer active)]

(In reply to comment #1)
> (From update of attachment 378317 [details] [diff] [review])
> This code change looks fine, but can you help me understand why it is that URL
> fields don't want RTL?  Is that just a universal rule?

Yes, because URLs are LTR natuarlly (i.e., they are read from left to right even for RTL langauges.  Without this, putting "http://mozilla.org/" inside that text box would make it appear as "/http://mozilla.org" because it's being shown as an RTL string.

> I'm very sad to say that I speak/read no RTL languages.

If you're interested to get a feel of the browser in an RTL locale, you can use the Force RTL extension <https://addons.mozilla.org/addon/7438>...  :-)

Comment 3

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/c013ca0da569

Comment 4

[Nochum Sossonko [:Natch]]

What guarantees that all these fixes won't regress? Just wondering, because I think it would be beneficial to add a comment by all of these explaining what the issue is. rtl is not really the first thing devs will think of...

Comment 5

[Johnathan Nightingale [:johnath]]

(In reply to comment #4)
> What guarantees that all these fixes won't regress? Just wondering, because I
> think it would be beneficial to add a comment by all of these explaining what
> the issue is. rtl is not really the first thing devs will think of...

In general - tests.  But in this case, the code change isn't explicitly RTL, it's just classing this url-field as... a URL field.  So that it will, in future, pick up styling changes we feel are appropriate to URL fields. This might actually prevent a regression somewhere down the line, or at least an inconsistency.

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 378317 [details] [diff] [review]
Patch (v1)

a191=beltzner

Comment 7

[u279076]

Litmus test case added:
https://litmus.mozilla.org/show_test.cgi?id=7726

Comment 8

[(no longer active)]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/e24bf87d6547