Closed Bug 493729 Opened 12 years ago Closed 12 years ago

URL text box in the exception dialog should always be LTR

Categories

(Core Graveyard :: Security: UI, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9.2a1

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

Details

(Keywords: fixed1.9.1, polish, rtl)

Attachments

(1 file)

Attached patch Patch (v1)Splinter Review
URL text box in the exception dialog should always be LTR, even in RTL locales.
Attachment #378317 - Flags: review?(johnath)
Attachment #378317 - Attachment is patch: true
Attachment #378317 - Attachment mime type: application/octet-stream → text/plain
Attachment #378317 - Flags: review?(johnath) → review+
Comment on attachment 378317 [details] [diff] [review]
Patch (v1)

This code change looks fine, but can you help me understand why it is that URL fields don't want RTL?  Is that just a universal rule? I'm very sad to say that I speak/read no RTL languages.
(In reply to comment #1)
> (From update of attachment 378317 [details] [diff] [review])
> This code change looks fine, but can you help me understand why it is that URL
> fields don't want RTL?  Is that just a universal rule?

Yes, because URLs are LTR natuarlly (i.e., they are read from left to right even for RTL langauges.  Without this, putting "http://mozilla.org/" inside that text box would make it appear as "/http://mozilla.org" because it's being shown as an RTL string.

> I'm very sad to say that I speak/read no RTL languages.

If you're interested to get a feel of the browser in an RTL locale, you can use the Force RTL extension <https://addons.mozilla.org/addon/7438>...  :-)
Keywords: polish
http://hg.mozilla.org/mozilla-central/rev/c013ca0da569
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-litmus?
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
Attachment #378317 - Flags: approval1.9.1?
What guarantees that all these fixes won't regress? Just wondering, because I think it would be beneficial to add a comment by all of these explaining what the issue is. rtl is not really the first thing devs will think of...
(In reply to comment #4)
> What guarantees that all these fixes won't regress? Just wondering, because I
> think it would be beneficial to add a comment by all of these explaining what
> the issue is. rtl is not really the first thing devs will think of...

In general - tests.  But in this case, the code change isn't explicitly RTL, it's just classing this url-field as... a URL field.  So that it will, in future, pick up styling changes we feel are appropriate to URL fields. This might actually prevent a regression somewhere down the line, or at least an inconsistency.
Comment on attachment 378317 [details] [diff] [review]
Patch (v1)

a191=beltzner
Attachment #378317 - Flags: approval1.9.1? → approval1.9.1+
Litmus test case added:
https://litmus.mozilla.org/show_test.cgi?id=7726
Flags: in-litmus? → in-litmus+
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.