Closed
Bug 493729
Opened 13 years ago
Closed 13 years ago
URL text box in the exception dialog should always be LTR
Categories
(Core Graveyard :: Security: UI, defect)
Core Graveyard
Security: UI
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.9.2a1
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
Details
(Keywords: fixed1.9.1, polish, rtl)
Attachments
(1 file)
1012 bytes,
patch
|
johnath
:
review+
beltzner
:
approval1.9.1+
|
Details | Diff | Splinter Review |
URL text box in the exception dialog should always be LTR, even in RTL locales.
Attachment #378317 -
Flags: review?(johnath)
Assignee | ||
Updated•13 years ago
|
Attachment #378317 -
Attachment is patch: true
Attachment #378317 -
Attachment mime type: application/octet-stream → text/plain
Updated•13 years ago
|
Attachment #378317 -
Flags: review?(johnath) → review+
Comment 1•13 years ago
|
||
Comment on attachment 378317 [details] [diff] [review] Patch (v1) This code change looks fine, but can you help me understand why it is that URL fields don't want RTL? Is that just a universal rule? I'm very sad to say that I speak/read no RTL languages.
Assignee | ||
Comment 2•13 years ago
|
||
(In reply to comment #1) > (From update of attachment 378317 [details] [diff] [review]) > This code change looks fine, but can you help me understand why it is that URL > fields don't want RTL? Is that just a universal rule? Yes, because URLs are LTR natuarlly (i.e., they are read from left to right even for RTL langauges. Without this, putting "http://mozilla.org/" inside that text box would make it appear as "/http://mozilla.org" because it's being shown as an RTL string. > I'm very sad to say that I speak/read no RTL languages. If you're interested to get a feel of the browser in an RTL locale, you can use the Force RTL extension <https://addons.mozilla.org/addon/7438>... :-)
Assignee | ||
Comment 3•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/c013ca0da569
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-litmus?
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
Assignee | ||
Updated•13 years ago
|
Attachment #378317 -
Flags: approval1.9.1?
Comment 4•13 years ago
|
||
What guarantees that all these fixes won't regress? Just wondering, because I think it would be beneficial to add a comment by all of these explaining what the issue is. rtl is not really the first thing devs will think of...
Comment 5•13 years ago
|
||
(In reply to comment #4) > What guarantees that all these fixes won't regress? Just wondering, because I > think it would be beneficial to add a comment by all of these explaining what > the issue is. rtl is not really the first thing devs will think of... In general - tests. But in this case, the code change isn't explicitly RTL, it's just classing this url-field as... a URL field. So that it will, in future, pick up styling changes we feel are appropriate to URL fields. This might actually prevent a regression somewhere down the line, or at least an inconsistency.
Comment 6•13 years ago
|
||
Comment on attachment 378317 [details] [diff] [review] Patch (v1) a191=beltzner
Attachment #378317 -
Flags: approval1.9.1? → approval1.9.1+
Litmus test case added: https://litmus.mozilla.org/show_test.cgi?id=7726
Flags: in-litmus? → in-litmus+
Assignee | ||
Comment 8•13 years ago
|
||
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/e24bf87d6547
Keywords: fixed1.9.1
Updated•6 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•