493784 - Silence hunspell warnings

Status: RESOLVED FIXED

(Core :: Spelling checker, defect)

Description

[timeless]

extensions/spellcheck/hunspell/src/hashmgr.cpp: In member function ‘int HashMgr::add_word(const char*, int, int, short unsigned int*, int, const char*, bool)’:
extensions/spellcheck/hunspell/src/hashmgr.cpp:225: warning: null argument where non-null required (argument 1)
extensions/spellcheck/hunspell/src/affentry.cpp: In member function ‘char* PfxEntry::check_morph(const char*, int, char, short unsigned int)’:
extensions/spellcheck/hunspell/src/affentry.cpp:422: warning: null argument where non-null required (argument 1)
extensions/spellcheck/hunspell/src/affixmgr.cpp: In member function ‘int AffixMgr::compound_check_morph(const char*, int, short int, short int, short int, short int, hentry**, char, char**, char*)’:
extensions/spellcheck/hunspell/src/affixmgr.cpp:2030: warning: null argument where non-null required (argument 1)
extensions/spellcheck/hunspell/src/affixmgr.cpp:2198: warning: null argument where non-null required (argument 1)
extensions/spellcheck/hunspell/src/affixmgr.cpp:2260: warning: null argument where non-null required (argument 1)
extensions/spellcheck/hunspell/src/affixmgr.cpp: In member function ‘char* AffixMgr::suffix_check_morph(const char*, int, int, AffEntry*, short unsigned int, short unsigned int, char)’:
extensions/spellcheck/hunspell/src/affixmgr.cpp:2691: warning: null argument where non-null required (argument 1)
extensions/spellcheck/hunspell/src/affixmgr.cpp:2749: warning: null argument where non-null required (argument 1)
extensions/spellcheck/hunspell/src/hunspell.cpp: In member function ‘int Hunspell::spell(const char*, int*, char**)’:
extensions/spellcheck/hunspell/src/hunspell.cpp:570: warning: unused variable ‘result’
extensions/spellcheck/hunspell/src/hunspell.cpp:551: warning: unused variable ‘corr’
extensions/spellcheck/hunspell/src/replist.cpp: In member function ‘int RepList::conv(const char*, char*)’:
extensions/spellcheck/hunspell/src/replist.cpp:112: warning: comparison between signed and unsigned integer expressions
extensions/spellcheck/hunspell/src/suggestmgr.cpp: In member function ‘char* SuggestMgr::suggest_morph(const char*)’:
extensions/spellcheck/hunspell/src/suggestmgr.cpp:1569: warning: null argument where non-null required (argument 1)

Comment 1

[timeless]

Attachment: fix warnings

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 378406 [details] [diff] [review]
fix warnings

Nemeth, is this something we should take now or will your next release take care of these?

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Fixed by bug 564608