493827 - Make version_win.pl able to use the app version from configure vars

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[Mark Banner (:standard8)]

Attachment: The fix

+++ This bug was initially created as a clone of Bug #316387 +++

This is from bug 288690 comment 7:
"We may want to replace the version number in module.ver as well, I realized in
the last days. I'll probably have to look into how to do it best in another bug
one time..."

---

Bug 316387 has done all the hard work for us (thanks KaiRo!) we just need to port it to Thunderbird and then we can change one less file on version bumps.

Comment 1

[Phil Ringnalda (:philor)]

Comment on attachment 378431 [details] [diff] [review]
The fix

I was going to object to the length of the strings (despite them being copied from Fx), but I guess the Win7 display ("Thunderbird is a Trademark of The Moz...") is an improvement over XP, where the n in according in the copyright string is cut in the middle, making it look like accordir. And since the copyright string for Microsoft apps is "(c) Microsoft Corporation. All rights reserv..." it must be the Windows Way to overflow Properties.

Oh, the gist of the patch: yay!

Comment 2

[Mark Banner (:standard8)]

Checked in: https://bugzilla.mozilla.org/show_bug.cgi?id=493827

Comment 3

[Mark Banner (:standard8)]

Suggested steps for occasional test (windows-only):

Install TB & Locate thunderbird.exe.

Right click & select properties. Select the Details tab. Checks:

- File Description and Product Name is 'Thunderbird' or 'Shredder' (nightly build) or something else if using a code name on an alpha release.
- Product Version is the expected version of the build, e.g. 3.0b3 or 3.0 or 3.0b3pre

This is slightly different on XP but the basic idea should be the same.

Comment 4

[Ludovic Hirlimann [:Usul]]

https://litmus.mozilla.org/show_test.cgi?id=7740