Closed Bug 493829 Opened 15 years ago Closed 15 years ago

The Tour/Promotion box needs to automatically scroll

Categories

(addons.mozilla.org Graveyard :: Public Pages, defect, P2)

defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: clouserw, Assigned: rdoherty)

References

()

Details

Attachments

(1 file, 1 obsolete file)

According to the spec (http://docs.google.com/Doc?id=dds6vwb4_15cq79x5gc&hl=en) the promotion box should rotate through it's contents every 5 seconds.
Target Milestone: --- → 5.0.6
Wil: Do we need to pick this up, or is this still Clearleft's job?
This is on us now.  I'm not sure it's a 5.0.6 blocker though.  Nick?
Assignee: nat → nobody
Not a blocker but a very nice to have.
Assignee: nobody → rdoherty
Priority: -- → P2
Attached patch v1 (obsolete) — Splinter Review
Making Nick happy.
Attachment #380950 - Flags: review?(clouserw)
Comment on attachment 380950 [details] [diff] [review]
v1

I really think this needs to be animated when it rotates like on the current front page.

When a user clicks and content changes it's not as big of a deal but I think it's important that the user realizes what is happening with the content and how to get back to it if they want to.

Also, the timer is never restarted onmouseout.
Attachment #380950 - Flags: review?(clouserw) → review-
Comment on attachment 380950 [details] [diff] [review]
v1

what the hell, it works fine this morning (still no timer restart).  r+
Attachment #380950 - Flags: review- → review+
Attached patch v2Splinter Review
v2, now with auto-restart!
Attachment #380950 - Attachment is obsolete: true
Attachment #381083 - Flags: review?(clouserw)
Attachment #381083 - Flags: review?(clouserw) → review+
r26900

For QA:
Expected functionality:

-Promo module at top of page will rotate to the next index every 5 seconds. It will loop around from the last index to the first.
-When mousing over the module, no animation will occur.
-When mousing off of the module, the animation will restart.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Verified FIXED on https://preview.addons.mozilla.org/en-US/firefox/; this was the most fun I've ever had testing, in a while.

I tested JS-disabled, too, and looks like we didn't regress the flat view; hot!
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: