The Tour/Promotion box needs to automatically scroll

VERIFIED FIXED in 5.0.6

Status

addons.mozilla.org Graveyard
Public Pages
P2
normal
VERIFIED FIXED
9 years ago
2 years ago

People

(Reporter: clouserw, Assigned: rdoherty)

Tracking

unspecified
5.0.6

Details

(URL)

Attachments

(1 attachment, 1 obsolete attachment)

v2
1.86 KB, patch
clouserw
: review+
Details | Diff | Splinter Review
(Reporter)

Description

9 years ago
According to the spec (http://docs.google.com/Doc?id=dds6vwb4_15cq79x5gc&hl=en) the promotion box should rotate through it's contents every 5 seconds.
(Reporter)

Updated

9 years ago
Target Milestone: --- → 5.0.6
Wil: Do we need to pick this up, or is this still Clearleft's job?
(Reporter)

Comment 2

9 years ago
This is on us now.  I'm not sure it's a 5.0.6 blocker though.  Nick?
Assignee: nat → nobody
Not a blocker but a very nice to have.
(Reporter)

Updated

9 years ago
Assignee: nobody → rdoherty
Priority: -- → P2
(Assignee)

Comment 4

9 years ago
Created attachment 380950 [details] [diff] [review]
v1

Making Nick happy.
Attachment #380950 - Flags: review?(clouserw)
(Reporter)

Comment 5

9 years ago
Comment on attachment 380950 [details] [diff] [review]
v1

I really think this needs to be animated when it rotates like on the current front page.

When a user clicks and content changes it's not as big of a deal but I think it's important that the user realizes what is happening with the content and how to get back to it if they want to.

Also, the timer is never restarted onmouseout.
Attachment #380950 - Flags: review?(clouserw) → review-
(Reporter)

Comment 6

9 years ago
Comment on attachment 380950 [details] [diff] [review]
v1

what the hell, it works fine this morning (still no timer restart).  r+
Attachment #380950 - Flags: review- → review+
(Assignee)

Comment 7

9 years ago
Created attachment 381083 [details] [diff] [review]
v2

v2, now with auto-restart!
Attachment #380950 - Attachment is obsolete: true
Attachment #381083 - Flags: review?(clouserw)
(Reporter)

Updated

9 years ago
Attachment #381083 - Flags: review?(clouserw) → review+
(Assignee)

Comment 8

9 years ago
r26900

For QA:
Expected functionality:

-Promo module at top of page will rotate to the next index every 5 seconds. It will loop around from the last index to the first.
-When mousing over the module, no animation will occur.
-When mousing off of the module, the animation will restart.
(Assignee)

Updated

9 years ago
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Verified FIXED on https://preview.addons.mozilla.org/en-US/firefox/; this was the most fun I've ever had testing, in a while.

I tested JS-disabled, too, and looks like we didn't regress the flat view; hot!
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.