493929 - Non aligned entity names for button label, accelerator and tooltip in extensions.dtd

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Dwayne Bailey]

It is important for localisers and for localisation tools that related texts for widgets be aligned.

Looking at extensions.dtd:

http://mxr.mozilla.org/mozilla-central/source/toolkit/locales/en-US/chrome/mozapps/extensions/extensions.dtd#65

You will notice:

<!ENTITY cmd.uninstall.label              "Uninstall">
<!ENTITY cmd.uninstall2.accesskey         "U">
<!ENTITY cmd.uninstall2.tooltip           "Uninstall this Add-on when &brandShortName; is restarted">

These are the label, accesskey and tooltip for a button. These should be aligned to all refer to cmd.uninstall. or cmd.uninstall2. so that a localiser can quickly see that these are associated, without that information they must either guess or go check the XUL code.  Naming them correctly will save lots of time for lots of localisers.

Comment 1

[Dwayne Bailey]

Also in the same file:

<!ENTITY cmd.about2.label                 "About this Add-on">
<!ENTITY cmd.about.accesskey              "A">

Please align cmd.about. and cmd.about2.

Comment 2

[Saint Wesonga]

Attachment: Patch

Comment 3

[Robert Strong (they/them - no direct email)]

Comment on attachment 416230 [details] [diff] [review]
Patch

It would likely be better to ask Dave Townsend for review on this. See the toolkit review sub-module owners.
http://www.mozilla.org/projects/toolkit/review.html

btw: has this requirement been documented and a notification sent out to the dev-platform mailing list?

I'll leave it up to you whether you change the review request to Dave or not in case you have already discussed this with Vlad. Keep in mind that there might not be much value in doing this at this time since Dave is working on a rewrite of the EM api and likely the UI as well.

Comment 4

[Robert Strong (they/them - no direct email)]

Axel, can you answer whether this requirement been documented and a notification sent out to the dev-platform, etc. mailing list? Thanks

Comment 5

[Saint Wesonga]

I don't know whether this change is still necessary, so I've switched the review request to Dave.

Comment 6

[Dave Townsend [:mossop]]

Not going to review this for now, I suspect this problem changes substantially when the UI changes happen so it isn't worth going any further on this bug right now.

Comment 7

[Dwayne Bailey]

(In reply to comment #5)
> I don't know whether this change is still necessary, so I've switched the
> review request to Dave.

The change is still needed.

(In reply to comment #6)
> Not going to review this for now, I suspect this problem changes substantially
> when the UI changes happen so it isn't worth going any further on this bug
> right now.

If the UI is changing then yes this might go away, if its not we'll still need to fix it.

Comment 8

[Saint Wesonga]

Fixed in bug 554007.