context menus in ftp wrong

VERIFIED FIXED

Status

P3
normal
VERIFIED FIXED
18 years ago
14 years ago

People

(Reporter: spam, Assigned: morse)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [nsbeta3+])

(Reporter)

Description

18 years ago
build ID 2000081709 M18 Linux

context menus when right-clicking over files in ftp have changed
they now contain this, most is redundant (and nothing downloads a file):

Open Link in New Window
-
Back
Forward
Reload
Stop
-
-
Bookmark This Link
Save Page As...
Save Link As...
-
Select All
Copy
Save Form Data
Prefill Form
Copy Link Location


-When right-clicking to bring up context menu, this error appears:
JavaScript error:
chrome://navigator/content/nsContextMenu.js line 438: formsArray has no properties

-If i then hit "Save Link As..." this error appears:
JavaScript error:
 line 0: contextMenu has no properties

Comment 1

18 years ago
In the case of an ftp or file:/// listing, window._content.document will be 
a XUL document, and .forms will be undefined. So the new routines that morse
added, okToPrefill and okToCapture, should just return false if 
window._content.document.forms is undefined (and then the context menu will
work as it did before for ftp/file listings). 
Assignee: pinkerton → morse

Comment 2

18 years ago
marking nsbeta3, simple fix, must-do otherwise ftp/file listing are broken.
Keywords: nsbeta3
content not toolkit
Assignee: morse → pchen
Component: XP Toolkit/Widgets: Menus → XP Apps

Comment 4

18 years ago
back to Steve, one more time ...
Assignee: pchen → morse
OS: Linux → All
Hardware: PC → All
(Assignee)

Updated

18 years ago
Status: NEW → ASSIGNED
Whiteboard: [nsbeta3+]
(Assignee)

Comment 5

18 years ago
Similar problem in edit menu.

Fixes checked in.  Files modified are nsContextMenu.js and utilityOverlay.js.
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED

Comment 6

18 years ago
verified on all builds that this is fixed and the unwanted items in context menu 
are no longer there. (2000091304). One question,Steve : are we not supposed to 
show the exact same menu items as seen in 4.x when right clicking on links? I 
see some menu items missing like "Open link in composer" ,"View Source", "View 
Info" . Marking this VERIFIED.
Status: RESOLVED → VERIFIED
(Assignee)

Comment 7

18 years ago
I have no idea what other items in the context menu are supposed to be shown.  
German is the person to ask about that.
Product: Core → Mozilla Application Suite
You need to log in before you can comment on or make changes to this bug.