49393 - context menus in ftp wrong

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect, P3)

Description

[R.K.Aa.]

build ID 2000081709 M18 Linux

context menus when right-clicking over files in ftp have changed
they now contain this, most is redundant (and nothing downloads a file):

Open Link in New Window
-
Back
Forward
Reload
Stop
-
-
Bookmark This Link
Save Page As...
Save Link As...
-
Select All
Copy
Save Form Data
Prefill Form
Copy Link Location


-When right-clicking to bring up context menu, this error appears:
JavaScript error:
chrome://navigator/content/nsContextMenu.js line 438: formsArray has no properties

-If i then hit "Save Link As..." this error appears:
JavaScript error:
 line 0: contextMenu has no properties

Comment 1

[John Morrison]

In the case of an ftp or file:/// listing, window._content.document will be 
a XUL document, and .forms will be undefined. So the new routines that morse
added, okToPrefill and okToCapture, should just return false if 
window._content.document.forms is undefined (and then the context menu will
work as it did before for ftp/file listings). 

Comment 2

[John Morrison]

marking nsbeta3, simple fix, must-do otherwise ftp/file listing are broken.

Comment 3

[Mike Pinkerton (not reading bugmail)]

content not toolkit

Comment 4

[John Morrison]

back to Steve, one more time ...

Comment 5

[Stephen P. Morse]

Similar problem in edit menu.

Fixes checked in.  Files modified are nsContextMenu.js and utilityOverlay.js.

Comment 6

[shrirang khanzode]

verified on all builds that this is fixed and the unwanted items in context menu 
are no longer there. (2000091304). One question,Steve : are we not supposed to 
show the exact same menu items as seen in 4.x when right clicking on links? I 
see some menu items missing like "Open link in composer" ,"View Source", "View 
Info" . Marking this VERIFIED.

Comment 7

[Stephen P. Morse]

I have no idea what other items in the context menu are supposed to be shown.  
German is the person to ask about that.