Closed Bug 493998 Opened 10 years ago Closed 10 years ago

Attendee in iTIP REQUEST always have role REQ-PARTICIPANT

Categories

(Calendar :: E-mail based Scheduling (iTIP/iMIP), defect, minor)

defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: gerhard.gossen, Assigned: gerhard.gossen)

Details

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.10) Gecko/2009042523 Ubuntu/9.04 (jaunty) Firefox/3.0.10
Build Identifier: Lightning 0.9 (build 2008091718)

Before sending an invitation, checkAndSendItipMessage() in calendar-item-editing.js resets the role of all participants to REQ-PARTICIPANT, even if another value is set. (See http://mxr.mozilla.org/mozilla/source/calendar/base/content/calendar-item-editing.js#578)

I want to use the role information in an ITipTransport, which only receives the 'corrected' version.

Reproducible: Always

Steps to Reproduce:
1. Create event with attendees.
2. Change role of one of the attendees (e.g. to OPT-PARTICIPANT)

Actual Results:  
ITipTransport receives event item with all attendee's role attribute being REQ-PARTICIPANT.

Expected Results:  
role attributes should contain the same information as in the calendar item.

The bug was introduced by the fix to bug 431522. Removing line 578 from calendar-item-editing.js or changing it to  

if (!attendee.role) {
    attendee.role = "REQ-PARTICIPANT";
}

should solve the problem.
Are you able to reproduce the issue using a Lightning 1.0pre nightly test build with Thunderbird 3 Beta 2 or newer?

I don't see anything related to |role| in the current version of this source file: http://mxr.mozilla.org/comm-central/source/calendar/base/content/calendar-item-editing.js
The code has moved to modules/calItipUtils.jsm, but the line is still the same. (http://mxr.mozilla.org/comm-central/source/calendar/base/modules/calItipUtils.jsm#330)

I have not managed to test it with 1.0pre, but the result should be the same. Is there any chance that a fix will go into a Thunderbird 2 compatible release?
I can reproduce the bug in yesterdays 1.0pre nightly (Thunderbird version: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b3pre) Gecko/20090223 Lightning/1.0pre Thunderbird/3.0b2).
- Your fix looks good, could you provide a patch, please?
- We won't do further releases for TB2.
Status: UNCONFIRMED → NEW
Ever confirmed: true
tested against HEAD, send message contains correct role information.
Assignee: nobody → gerhard.gossen
Status: NEW → ASSIGNED
Attachment #378898 - Flags: review?(dbo.moz)
Comment on attachment 378898 [details] [diff] [review]
set default attendee role only if no role is set

r=dbo
Attachment #378898 - Flags: review?(dbo.moz) → review+
Checked in: http://hg.mozilla.org/comm-central/rev/6a3fa2c0c0d4
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 1.0
These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".
Target Milestone: 1.0 → 1.0b1
You need to log in before you can comment on or make changes to this bug.