Closed Bug 494063 Opened 15 years ago Closed 15 years ago

Add prefs to disable Access-Control

Categories

(Core :: DOM: Core & HTML, defect)

x86
Windows XP
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: sicking, Assigned: sicking)

Details

(Keywords: fixed1.9.1)

Attachments

(1 file)

Realized that we really should have prefs to disable our cross-site XHR support, in case there's bugs or for whatever other reason. I also added a pref to disable just the loading of private data since from a security point of view that is the most controversial aspect.
Attached patch Patch to fixSplinter Review
Also contains a small conformance fix which is why tests were needed.

I don't yet have tests for the actual prefs, but I ran the test suite manually with the different prefs enabled and the right tests were failing.

I'll write up a automatic test as soon as possible.
Assignee: nobody → jonas
Attachment #378714 - Flags: superreview?(jst)
Attachment #378714 - Flags: review?(jst)
Attachment #378714 - Flags: approval1.9.1?
Attachment #378714 - Flags: superreview?(jst)
Attachment #378714 - Flags: superreview+
Attachment #378714 - Flags: review?(jst)
Attachment #378714 - Flags: review+
Attachment #378714 - Flags: approval1.9.1?
Attachment #378714 - Flags: approval1.9.1+
Flags: blocking1.9.1?
Checked in everywhere yesterday:

http://hg.mozilla.org/mozilla-central/rev/3efa18f4298f
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/08d3a3688cf2
Status: NEW → RESOLVED
Closed: 15 years ago
Keywords: fixed1.9.1
Resolution: --- → FIXED
(Not a blocker, though glad it's fixed!)
Flags: blocking1.9.1? → blocking1.9.1-
Flags: in-testsuite+
There's no tests in the test suite for this yet. I did test manually before checking in by setting the prefs and running the tests that we have in the tree and checked that the right ones failed, but there's no automated tests yet.
Flags: in-testsuite+ → in-testsuite?
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: