494093 - Symbian specific patch to mmgc/avm.

Status: VERIFIED FIXED

(Tamarin Graveyard :: Virtual Machine, defect, P2)

Description

[Samuli Kekki]

User-Agent:       Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 5.1; Trident/4.0; GTB5; .NET CLR 2.0.50727; .NET CLR 3.0.04506.648; .NET CLR 3.5.21022)
Build Identifier: 

Adds new API VMPI_areNewPagesDirty (fixes a crash on Symbian) for MMgc and basic Symbian build fixes, mostly just stubbed out functions. The new API was discussed with Thomas when I did it in Flash code base.

Reproducible: Always

Comment 1

[Samuli Kekki]

Attachment: Symbian specific patch.

Comment 2

[Steven Johnson]

Comment on attachment 378748 [details] [diff] [review]
Symbian specific patch.

rerouting to tommy for review.

Comment 3

[Lars T Hansen]

Comment on attachment 378748 [details] [diff] [review]
Symbian specific patch.

The change to PosixPortUtils.cpp is in principle not acceptable.  If Symbian is not Posix then it needs its own implementation of these routines, in a separate file.  I see that there is some proliferation of platform #ifdefs in PosixPortUtils.cpp already, but this is not something we should make worse.  We could accept this one change, but we should plan to clean it up ASAP.

No objections to the rest of it.

Comment 4

[Tommy Reilly]

Comment on attachment 378748 [details] [diff] [review]
Symbian specific patch.

Looks good want me to push this for you?

Comment 5

[Samuli Kekki]

(In reply to comment #3)
> (From update of attachment 378748 [details] [diff] [review])
> The change to PosixPortUtils.cpp is in principle not acceptable.  If Symbian is
> not Posix then it needs its own implementation of these routines, in a separate
> file.  I see that there is some proliferation of platform #ifdefs in
> PosixPortUtils.cpp already, but this is not something we should make worse.  We
> could accept this one change, but we should plan to clean it up ASAP.
> No objections to the rest of it.

Hi Lars. We discussed about this within email. You mentioned that you are fine with this at the moment. If the changes grow we fork the file. I agree. It is beneficial for Symbian to use the same files at this point. Symbian can use PosixPortUtils.cpp and ThreadsPosix.cpp.

Comment 6

[Samuli Kekki]

(In reply to comment #4)
> (From update of attachment 378748 [details] [diff] [review])
> Looks good want me to push this for you?

Yes please, and thanks.

Comment 7

[Steven Johnson]

Lars/Rishit, if this hasn't been pushed yet, could one of you do so this week (since Tommy is on PTO)?

Comment 8

[Lars T Hansen]

(In reply to comment #7)
> Lars/Rishit, if this hasn't been pushed yet, could one of you do so this week
> (since Tommy is on PTO)?

I'll take care of it.

Comment 9

[Lars T Hansen]

A lot of this has also been absorbed into bug #489345 (oom implementation).  I will land that patch first, then see if anything else is needed from this one.

Comment 10

[Lars T Hansen]

landed with redux changeset: 2001:37483f093b65 (oom implementation).

Comment 11

[Chris Peyer]

Resolved fixed engineering / work item that has been pushed.  Setting status to verified.