494099 - invalid read test_bug381412.hk.gb2312.js

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[Robert Sayre]

see attached

Comment 1

[Robert Sayre]

Attachment: valgrind log

Comment 2

[Simon Montagu :smontagu]

Bug 90411 is closely related to this.

Comment 3

[Simon Montagu :smontagu]

Attachment: Patch

So bug 90411 and this are two sides of the same coin: the decoder doesn't take into account that a multi-byte sequence can be split across buffer boundaries, so on the one hand it tries to read to the end of the sequence beyond the end of the input, and on the other hand it fails to decode the end of the sequence correctly at the beginning of the next buffer.

Comment 4

[Masatoshi Kimura [:emk]]

Comment on attachment 381280 [details] [diff] [review]
Patch

> +    if (!oddByte) {
> +      if (srcByte & 0x80 || srcByte == HZLEAD1 || mHZState == HZ_STATE_GB) { 
> +        oddByte = srcByte;
NUL bytes will be ignored in GB mode. Is it intentional?

Comment 5

[Simon Montagu :smontagu]

Attachment: patch v.2

Yes, good catch, it wasn't intentional :)

Comment 6

[Simon Montagu :smontagu]

http://hg.mozilla.org/mozilla-central/rev/92a9095b9b0b