TM: many math trace tests fail on 1.9.1 branch

RESOLVED WONTFIX

Status

()

Core
JavaScript Engine
--
critical
RESOLVED WONTFIX
9 years ago
7 years ago

People

(Reporter: graydon, Assigned: bc)

Tracking

1.9.1 Branch
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

9 years ago
It seems due to the absence of tinderbox-integrated unit-testing of trace-test.js, and the fact that most of the JS team is working on TM branch not 1.9.1 branch, we've let the 1.9.1 branch slip into "not passing" for a number of tests that touch Math. Most of the trig, abs, ceil, etc. tests fail.

Will need to isolate and fix, this should block.
Flags: blocking1.9.1?
(Reporter)

Comment 1

9 years ago
Note also that landing bug 473989 -- making trace-test.js run as part of tinderbox -- would be keen as well.
yeah, math matters.
Flags: blocking1.9.1? → blocking1.9.1+

Comment 3

9 years ago
Dropping blocking (not sure what the protocol is and whether its ok for me to do that myself, but hey its 2am).

The trunk version of trace-tests.js passes fine. branch has an outdated test harness. I suggest copying over the trunk version once all related fixes have been merged (right now testNewArrayCount2 fails on branch, because the corresponding fix hasn't landed on branch yet).

Assigning to graydon since he was fiddling with running tests automatically. Assign back to me if unwanted, but should be general@js.
Assignee: general → graydon
Flags: blocking1.9.1+
Andreas: I'm happy to leave this off the blocker list as long as you guarantee me that this will happen before we ship the RC. We need to make sure that we have the right tests testing 191 before we can freeze.
Bob: can you help us get trace-tests on 1.9.1 updated and covered?  This sort of thing sets my spidey sense on _fire_, and you have the diligence and thoroughness we need at this stage of the game. :)
Assignee: graydon → bclary
Two years later, safe to say WONTFIX?
3 months and no response. 1.9.1 is no longer a supported branch.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.