Closed Bug 494115 Opened 15 years ago Closed 15 years ago

Some binaries that hit the fallback code have their .sym paths written 2x in symbols.txt

Categories

(Camino Graveyard :: General, defect)

All
macOS
defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: alqahira, Assigned: stuart.morgan+bugzilla)

References

()

Details

Attachments

(1 file)

I don't think there's any harm in this[1], but certain binaries that hit the fallback path (*cough*NSS*cough*) end up having their .sym paths written twice to the respective symbols.txt file.

[1] though I don't know how good the code for the symbol cleaning scripts might be; I suppose it's possible the code could choke trying to remove the symbols a second time :P
Attached patch fixSplinter Review
Names of empty symbol files won't be printed (the reason all the fallback symbols didn't do this is some had the 000...000 GUID, and I was skipping those early in the process. And just to be thorough (although it shouldn't actually matter since we'll overwrite the file anyway), also remove the file and any now-empty directories it made.
Assignee: nobody → stuart.morgan+bugzilla
Status: NEW → ASSIGNED
Landed on CVS trunk.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: