dehydra numeric range tests too sensitive [64-bit]

RESOLVED FIXED

Status

RESOLVED FIXED
10 years ago
10 months ago

People

(Reporter: bradh, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

10 years ago
User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.0.10) Gecko/2009042708 Fedora/3.0.10-1.fc9 Firefox/3.0.10
Build Identifier: 

Running the test_numinfo.js test on my AMD64 box results in:
$ /home/bradh/devel/gcc-build/gcc/cc1plus -quiet -O1 -ftest-coverage -fplugin=../gcc_dehydra.so -o /dev/null -fplugin-arg-gcc_dehydra-script=test_numinfo.js numinfo.cc
numinfo.cc:23: error: Expected '-9223372036854775808', got '-9223372036854775808l'
numinfo.cc:23: error: Expected '0u', got '0ul'
ERR  TestCase   Error: false is false
ERR  TestCase   Error: false is false



Reproducible: Always




Will attach a simple patch
(Reporter)

Comment 1

10 years ago
Created attachment 378806 [details] [diff] [review]
patch to fix dehydra test problem

Basically I'm just extending the regex in the easiest way I know. There is probably some more elegant way, but this was obvious.
Attachment #378806 - Flags: review?(tglek)
(Reporter)

Updated

10 years ago
Blocks: 484865

Comment 2

10 years ago
pushed a slightly different regexp, thanks for diagnosing this.

http://hg.mozilla.org/users/tglek_mozilla.com/dehydra-gcc/rev/278d1084ea81
Status: UNCONFIRMED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED

Updated

9 years ago
Attachment #378806 - Flags: review?(tglek)

Updated

10 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.