494133 - Set As Desktop Background not available when Prism extension is installed

Status: RESOLVED FIXED

(Mozilla Labs :: Prism, defect)

Description

[Matthew Gertner]

When the Prism for Firefox extension is installed, the Set As Desktop Background option no longer appears in the context menu for images. I suspect this has something to do with the fact that we have our own nsIShellService, but I'll have to look into it.

Comment 1

[Matthew Gertner]

Problem is here I guess: http://mxr.mozilla.org/mozillasvn/source/projects/webrunner/extension/build/Makefile.in#59. We definitely shouldn't be copying the nsIShellService.xpt file into the extension.

Comment 2

[Matthew Gertner]

Or rather, we should probably rename the interface since there is a single prism.xpt file, and some of the interfaces are used by the extension.

Comment 3

[keegkey]

Hy, is this problem fixed already, does anyone even works on it?

Comment 4

[Matthew Gertner]

Sorry, I know exactly what causes this problem and how to fix it. Just haven't gotten to it yet. I do consider it a high priority and will make sure a fix gets into the next Prism release.

Comment 6

[Matthew Gertner]

Attachment: Calling this interface nsIShellService was a totally bad idea

Comment 7

[Ryan Lewandowski]

When do you anticipate this issue being resolved?

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 420741 [details] [diff] [review]
Calling this interface nsIShellService was a totally bad idea

I'm not a big fan of nsIProtocolShellService. How about nsIWebProtocolService ?

r+ otherwise.

Comment 9

[Matthew Gertner]

Okay I changed it to nsIWebProtocolService.

Sending        components/public/Makefile.in
Deleting       components/public/nsIShellService.idl
Adding         components/public/nsIWebProtocolService.idl
Sending        components/src/mac/nsDesktopEnvironmentMac.h
Sending        components/src/mac/nsDesktopEnvironmentMac.mm
Sending        components/src/nsPlatformGlue.js
Sending        components/src/windows/nsDesktopEnvironmentWin.cpp
Sending        components/src/windows/nsDesktopEnvironmentWin.h
Transmitting file data .......
Committed revision 59494.