Closed
Bug 494152
Opened 15 years ago
Closed 15 years ago
eliminate onnewtab and the NewTab event
Categories
(Firefox :: Tabbed Browser, defect)
Firefox
Tabbed Browser
Tracking
()
VERIFIED
FIXED
Firefox 3.7a1
People
(Reporter: dao, Assigned: dao)
Details
Attachments
(1 file, 1 obsolete file)
5.82 KB,
patch
|
asaf
:
review+
|
Details | Diff | Splinter Review |
Double-clicking the tab strip dispatches a NewTab event, which isn't really useful anymore. We can just call BrowserOpenTab directly. If there's a reason to avoid that extra dependency on browser.js, cmd_newNavigatorTab could also be used (it's already used for the new-tab button).
Attachment #378833 -
Flags: review?(gavin.sharp)
Comment 1•15 years ago
|
||
What about http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.xul?mark=558-558#542 ? Probably just removing that would work...
Comment 2•15 years ago
|
||
Also: http://mxr.mozilla.org/mozilla-central/source/browser/base/content/tabbrowser.xml#87 which seems like it depends on: http://mxr.mozilla.org/mozilla-central/source/browser/base/content/tabbrowser.xml#131 . It seems like the whole thing was introduced for the sidebar, the content tabbrowser doesn't have an onnewtab handler (only the NewTab event listener)...
Assignee | ||
Comment 3•15 years ago
|
||
onnewtab is technically independent of the NewTab event, but yeah, it makes sense to eliminate that here as well. There's no tabbrowser in the sidebar, though.
Assignee | ||
Updated•15 years ago
|
Summary: eliminate the NewTab event → eliminate onnewtab and the NewTab event
Assignee | ||
Comment 4•15 years ago
|
||
onnewtab added
Attachment #378833 -
Attachment is obsolete: true
Attachment #384274 -
Flags: review?(gavin.sharp)
Attachment #378833 -
Flags: review?(gavin.sharp)
Comment 5•15 years ago
|
||
Comment on attachment 384274 [details] [diff] [review] patch r=mano
Attachment #384274 -
Flags: review?(gavin.sharp) → review+
Assignee | ||
Comment 6•15 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/9321f1c3ec62
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.7a1
Comment 7•15 years ago
|
||
(In reply to comment #3) > There's no tabbrowser in the sidebar, though. Just a reminder, I believe Alex Limi is currently mocking up Tab Sidebar designs: http://limi.net/articles/reinventing-tabs-for-the-browser
Comment 8•15 years ago
|
||
Everything works fine. Verified fixed with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.3a1pre) Gecko/20091221 Minefield/3.7a1pre ID:20091221034526
Status: RESOLVED → VERIFIED
Comment 9•14 years ago
|
||
This broke the following extensions: New Tab Homepage <https://addons.mozilla.org/de/firefox/addon/777> New Tab King <https://addons.mozilla.org/de/firefox/addon/10828> Potentially broken: Fast Dial <https://addons.mozilla.org/de/firefox/addon/5721> Not broken: Auto Dial <https://addons.mozilla.org/de/firefox/addon/8615> (hacks into browser source code) New Tab Jumpstart <https://addons.mozilla.org/de/firefox/addon/8914> (uses "TabOpen" event, but that is triggered for link-clicks etc. too.) Extensions need a hookup point to know when a new tab has been opened, e.g. to implement Speed Dial pages like Google Chrome and Opera have. See bug 561749.
Assignee | ||
Comment 10•14 years ago
|
||
The NewTab event didn't do what you think it did. It was dispatched for double clicks on the tab strip only.
Comment 11•14 years ago
|
||
It's what the extension authors thought, apparently. Please notify the above extension authors and point them to bug 561749.
Comment 12•14 years ago
|
||
I notified extension authors.
You need to log in
before you can comment on or make changes to this bug.
Description
•