494152 - eliminate onnewtab and the NewTab event

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Dão Gottwald [:dao]]

Attachment: patch

Double-clicking the tab strip dispatches a NewTab event, which isn't really useful anymore. We can just call BrowserOpenTab directly. If there's a reason to avoid that extra dependency on browser.js, cmd_newNavigatorTab could also be used (it's already used for the new-tab button).

Comment 1

[Nochum Sossonko [:Natch]]

What about http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.xul?mark=558-558#542 ?

Probably just removing that would work...

Comment 2

[Nochum Sossonko [:Natch]]

Also:

http://mxr.mozilla.org/mozilla-central/source/browser/base/content/tabbrowser.xml#87

which seems like it depends on:

http://mxr.mozilla.org/mozilla-central/source/browser/base/content/tabbrowser.xml#131 .

It seems like the whole thing was introduced for the sidebar, the content tabbrowser doesn't have an onnewtab handler (only the NewTab event listener)...

Comment 3

[Dão Gottwald [:dao]]

onnewtab is technically independent of the NewTab event, but yeah, it makes sense to eliminate that here as well.

There's no tabbrowser in the sidebar, though.

Comment 4

[Dão Gottwald [:dao]]

Attachment: patch

onnewtab added

Comment 5

[Asaf Romano (gone)]

Comment on attachment 384274 [details] [diff] [review]
patch

r=mano

Comment 6

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/9321f1c3ec62

Comment 7

[[not reading bugmail]]

(In reply to comment #3)

> There's no tabbrowser in the sidebar, though.

Just a reminder, I believe Alex Limi is currently mocking up Tab Sidebar designs:
http://limi.net/articles/reinventing-tabs-for-the-browser

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Everything works fine. Verified fixed with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.3a1pre) Gecko/20091221 Minefield/3.7a1pre ID:20091221034526

Comment 9

[Ben Bucksch (:BenB)]

This broke the following extensions:
New Tab Homepage <https://addons.mozilla.org/de/firefox/addon/777>
New Tab King <https://addons.mozilla.org/de/firefox/addon/10828>

Potentially broken:
Fast Dial <https://addons.mozilla.org/de/firefox/addon/5721>
Not broken:
Auto Dial <https://addons.mozilla.org/de/firefox/addon/8615>
 (hacks into browser source code)
New Tab Jumpstart <https://addons.mozilla.org/de/firefox/addon/8914>
 (uses "TabOpen" event, but that is triggered for link-clicks etc. too.)

Extensions need a hookup point to know when a new tab has been opened, e.g. to implement Speed Dial pages like Google Chrome and Opera have. See bug 561749.

Comment 10

[Dão Gottwald [:dao]]

The NewTab event didn't do what you think it did. It was dispatched for double clicks on the tab strip only.

Comment 11

[Ben Bucksch (:BenB)]

It's what the extension authors thought, apparently. Please notify the above extension authors and point them to bug 561749.

Comment 12

[Ben Bucksch (:BenB)]

I notified extension authors.