Add link to Collections in category chooser

VERIFIED FIXED in 5.0.6

Status

VERIFIED FIXED
10 years ago
3 years ago

People

(Reporter: fligtar, Assigned: lorchard)

Tracking

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

10 years ago
Let's add a link to /collections labeled "Collections" in the category chooser between the divider and the Dictionaries link.

Also, I think the divider is a bit too long on the right? Doesn't look centered to me.
(Assignee)

Comment 1

10 years ago
Created attachment 378928 [details] [diff] [review]
hardcoding Collections into category list, tweaking margins on list

This patch should do the job
Attachment #378928 - Flags: review?(jbalogh)
Comment on attachment 378928 [details] [diff] [review]
hardcoding Collections into category list, tweaking margins on list

I will recommend this patch to all my friends.

>diff --git a/site/app/webroot/css/amo2009/main-mozilla.css b/site/app/webroot/css/amo2009/main-mozilla.css
>index 86bcfa2..94c2ba4 100644
>--- a/site/app/webroot/css/amo2009/main-mozilla.css
>+++ b/site/app/webroot/css/amo2009/main-mozilla.css
>@@ -15,6 +15,10 @@
>     clear: left;
> }
> 
>+.categories ul {
>+    padding: 1em 1em 1em 1em;
>+}
>+

Could you just do "padding: 1em;"?
Attachment #378928 - Flags: review?(jbalogh) → review+
(Assignee)

Comment 3

10 years ago
I could've done "padding: 1em", but I was feeling spunky and repetitive.  

But, for you: I will change it.  Checked in as r26054
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Verified FIXED:

On https://preview.addons.mozilla.org/en-US/firefox/ and other pages, the category-chooser menu has:

<a href="/en-US/firefox/collections/" >Collections</a>                </li>
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.