Don't fix rect in nsThebesImage, assert rect is sane

NEW
Unassigned

Status

()

--
major
9 years ago
5 years ago

People

(Reporter: joe, Unassigned)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

9 years ago
Created attachment 378910 [details] [diff] [review]
Don't fix the rect, assert it's sane

As a spinoff of bug 488685, we should simply assert that the decoded rect is sane, not fix the rect. Decoders should be smarter.
Attachment #378910 - Flags: superreview?(roc)
Attachment #378910 - Flags: review?(vladimir)
Isn't ABORT_IF_FALSE a bit heavy handed?  I'd just do a NS_ASSERTION, but maybe abort is actually better... since it means someone will fix whatever the problem is. :-)
(Reporter)

Comment 2

9 years ago
Yeah, I'm just trying to make sure people notice :) One day NS_ASSERTION will be fatal, but now is not that day.
Attachment #378910 - Flags: superreview?(roc)
Attachment #378910 - Flags: superreview+
Attachment #378910 - Flags: review?(vladimir)
Attachment #378910 - Flags: review+

Comment 3

9 years ago
is there an patch to fix all the decoders, or is this not an actual problem?
It came out of the linked bug above; the only decoder that had the problem was the GIF decoder, and that bug was fixed.
nThebesImage is done, we have gfxDrawables now.
(Reporter)

Updated

5 years ago
Assignee: joe → nobody
You need to log in before you can comment on or make changes to this bug.