494282 - Need to click "cancel" twice to get rid of the installation confirmation pop-up for add-ons featured on the homepage

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[krupa raj[:krupa]]

steps to reproduce:
1.Go to AMO homepage
2.In the introductory section for anonymous users,select "news"
3.click "Add to firefox"
4.In the installation confirmation pop-up box,click"cancel"

expected results:
pop-up box disappears and installation is aborted

actual result:
Need to click "cancel" twice to get rid of the installation confirmation pop-up for add-ons featured on the homepage


screencast:http://screencast.com/t/5HIeSwujraz

additional info:same behavior noticed for all add-ons featured in the homepage.works fine when installing the same addons from search/details page

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

We must somehow be firing two installTrigger() events?

Comment 2

[Wil Clouser [:clouserw]]

-> lorchard for front page stuff.  Sorry if it's not your fault. :)

Comment 3

[Les Orchard [:lorchard]]

FWIW - The install buttons are largely a mystery to me.  I won't be able to fix this until I spend a lot more time dissecting them to figure out what's going on.  

Probably a good thing for me to do that anyway to learn, but this will get fixed faster if someone who knows the install buttons better takes a look at it too.

Comment 4

[Les Orchard [:lorchard]]

Huh... seems like the install buttons don't like it when 2 instances of the same addon appear on the same page.  That seems to be the only way I can reproduce this.

Comment 5

[Les Orchard [:lorchard]]

Passing the buck.

Comment 6

[Alex Buchanan [:abuchanan]]

Attachment: patch v1

Comment 7

[Les Orchard [:lorchard]]

Comment on attachment 379258 [details] [diff] [review]
patch v1

Works for me - looks like a more general solution to get the event handlers attached

Comment 8

[Alex Buchanan [:abuchanan]]

r26279 commits patch v1

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

This didn't fix it for me using Firefox 3.0.1 on Mac OS X 10.4; reopening.

Comment 10

[Alex Buchanan [:abuchanan]]

I realized there is an amo2009 version of the files I edited for this bug.  

webroot/js/addons.js vs. webroot/js/amo2009/addons.js
views/elements/install.thtml vs views/elements/amo2009/install.thtml

What's the status of these amo2009 branches?  How should I go about applying my changes to these files?

For future bugs, will I edit the amo2009 version? both? or will they be merged together?

Thanks

Comment 11

[Les Orchard [:lorchard]]

Do all edits for the new layout in amo2009 directories.  It's not a branch so much as a way to allow pages still in the original style to co-exist with the new stuff until we've covered everything, so that getting the new style in place isn't an all-or-nothing effort.  The split might stick around for a long while.

Comment 12

[Alex Buchanan [:abuchanan]]

r26361 patches the amo2009 versions of the files I changed. 

Looks fixed on preview.

Comment 13

[krupa raj[:krupa]]

Looks fixed now.Marking it verified.