494301 - Scrollbar not resized on Pill button click

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect, P2)

Description

[Paul O'Shannessy [:zpao] (not reading much bugmail, email directly)]

Attachment: Bug in Action

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1pre) Gecko/20090521 Shiretoko/3.5pre ID:20090521030957

So instead of resizing the vertical scrollbar when the pill (remove toolbar) button is clicked, it just gets shifted up (by what looks like the height of the toolbar).

STR:
1. Navigate to page that requires scrolling.
2. Press Pill button to remove toolbar.

Expected Behavior:
1. Scrollbar is resized.

(confirmed with new profile; presumably applies to trunk, but didn't test)

Comment 1

[Samuel Sidler (old account; do not CC)]

This doesn't happen with Firefox 3, so it's a regression in the last year...

Comment 2

[philippe (part-time)]

Isn't this a dupe of bug 451641 ?

Comment 3

[Paul O'Shannessy [:zpao] (not reading much bugmail, email directly)]

(In reply to comment #2)
> Isn't this a dupe of bug 451641 ?

If bug 489891 is, then this is.

Comment 4

[Johnathan Nightingale [:johnath]]

dup'd bug is blocking - clear blocking on this one.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Un-duping for a quick fix.

Comment 6

[Markus Stange [:mstange]]

Attachment: v1

There's a number of cases that this approach gets wrong, for example collapsing a toolbar when the statusbar is hidden will cause the scrollbar to go under the resizer... but all in all it's better than before bug 56488 and fixes the special case of this bug (collapsing toolbars with statusbar visible).

I thought about adding a ContainsZeroSizedPoint method to nsRect, but I don't think it's worth it just for this one use case.

Comment 7

[Markus Stange [:mstange]]

http://hg.mozilla.org/mozilla-central/rev/1fa6860af3d6

Comment 8

[Chris Pearce [:cpearce (Not reading bugmail)]]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/909b2e13bb6b