494321 - Drop amo2009 on some more pages

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Wil Clouser [:clouserw]]

Attachment: /users/

We should put the amo2009 styles on some more pages.  This bug is vague because as soon as it gets too long I'm closing it and opening a new one. :)

First up - /users/

Comment 1

[Wil Clouser [:clouserw]]

Attachment: /pages/

Pretty straight forward

Comment 2

[Les Orchard [:lorchard]]

Comment on attachment 379016 [details] [diff] [review]
/users/

Patch applied, ran through user login/signup/delete/etc and things looked good.

Comment 3

[Ryan Doherty (:rdoherty)]

Comment on attachment 379034 [details] [diff] [review]
/pages/

Pages look ok and work. Consistency of headings between them is not very high, but that is another bug.

Comment 5

[Wil Clouser [:clouserw]]

Thanks.

r26109 for /users/
r26112 for /pages/

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

I can haz https://preview.addons.mozilla.org/en-US/firefox/search and its ilk reskinned? kthxbye

Comment 7

[Wil Clouser [:clouserw]]

Attachment: /search/

When combined with the fix for bug 495386 this should bring us on par with the current pages.  The results are a lot less dense (no screenshot, etc.) but it seems like that is the way we're going these days.  We can add class="primary" to the main <div> when we're ready to add the search bar on the side for the new design, so I think it's good the way it is.

I'm using the homepage_addon element on this page because it seems to fit well - is there a reason you named that specifically for the homepage?

Comment 8

[Les Orchard [:lorchard]]

Comment on attachment 380367 [details] [diff] [review]
/search/

Looks like without a class="primary", this layout breaks in IE7 even with the patch I posted for bug 495372

You might want to add the inverse body class, and class="primary" to the div - and if you want it to fill the space without a column, you can add another class with width: 100% to clobber the width: 73.47% defined for .primary

Comment 9

[Les Orchard [:lorchard]]

Oh, and homepage_addon was named that because I figured it would only be mostly useful on the home page.  Looked like other pages used different addon layouts.  I didn't see a mockup for a search page that used it

Comment 10

[Wil Clouser [:clouserw]]

Attachment: /search/ v2

Only changes are adding inverse, class=primary, and width:100%

Comment 11

[Les Orchard [:lorchard]]

Comment on attachment 380483 [details] [diff] [review]
/search/ v2

Inline styles are oogly, but good enough for a TODO

Comment 12

[Wil Clouser [:clouserw]]

(In reply to comment #11)
> (From update of attachment 380483 [details] [diff] [review])
> Inline styles are oogly, but good enough for a TODO

r26591

Gonna call this bug fixed since other pages are popping up in their own bugs.

Comment 13

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; https://preview.addons.mozilla.org/en-US/firefox/search?q=t&cat=all is looking good.  Advanced search (and even some simple queries) are broken, but that's bug 495386, and out of scope for this bug.