494342 - aux_base_name is not available during plugin_init in GCC 4.5

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[Brad Hards]

User-Agent:       Mozilla/5.0 (compatible; Konqueror/4.2; Linux) KHTML/4.2.3 (like Gecko) Fedora/4.2.3-2.fc9
Build Identifier: 

During make check on dehydra, I get:
/home/bradh/devel/gcc-build/gcc/cc1plus -quiet -O1 -ftest-coverage -fplugin=../gcc_dehydra.so -o /dev/null -fplugin-arg-gcc_dehydra-script=test_sys_gcc_info.js empty.cc                   
ERR  TestCase   Error: undefined != empty

There is an equivalent test failure for treehydra if that is also tested

Reproducible: Always




I'm not really sure about the actual test. It is testing for a specific behaviour that may not be sensible:

this.assertEquals(sys.aux_base_name, "empty");

(note it is testing for a string equivalence, not that the string is empty or null).

So I don't think it would be a big deal to just delete that specific test as an alternative to this patch.

Comment 1

[Brad Hards]

Attachment: patch to fix broken gcc sysinfo test

Comment 2

[(dormant account)]

As discussed on irc, the testcase was very valid. Committed a proper fix.

http://hg.mozilla.org/users/tglek_mozilla.com/dehydra-gcc/rev/8eb868e7d4c9