If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Better query for mDBGetItemProperties

VERIFIED FIXED in mozilla1.9.2a1

Status

()

Toolkit
Places
VERIFIED FIXED
9 years ago
8 years ago

People

(Reporter: mak, Assigned: mak)

Tracking

({verified1.9.1})

Trunk
mozilla1.9.2a1
verified1.9.1
Points:
---
Bug Flags:
wanted1.9.1 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
Created attachment 379123 [details] [diff] [review]
patch v1.0

Sqlite analyze teels me this takes about half the steps of the previous one.
Attachment #379123 - Flags: review?(sdwilsh)
(Assignee)

Updated

9 years ago
Severity: critical → normal

Updated

9 years ago
Attachment #379123 - Flags: review?(sdwilsh) → review+
Comment on attachment 379123 [details] [diff] [review]
patch v1.0

Um, yeah.  That gets rid of two subselects, so it should be waay faster.  I think I have blame for reviewing this, so shame on me for not thinking of this before...

r=sdwilsh
(Assignee)

Comment 2

9 years ago
when i originally created that patch sqlite was not compiling this query, so could be sqlite parser has been enhanced. this is what i recall but was some time ago.
(Assignee)

Comment 3

8 years ago
Comment on attachment 379123 [details] [diff] [review]
patch v1.0

no risk change to a query, makes it double as fast, asking pre approval.
Attachment #379123 - Flags: approval1.9.1?
When do we use this query?  On all bookmark gets?  Really?
(Assignee)

Comment 5

8 years ago
when getting informations on a single bookmark through the API, like getting the type of the bookmark (folder, uri, livemark). Not for usual folder queries (those use mDBGetChildren)
Btw when i say double as fast we talk about really small times around a couple ms. still something that in some situation (batching bookmarks removal/add) is often used.
(Assignee)

Updated

8 years ago
Flags: wanted1.9.1?
Flags: wanted1.9.1? → wanted1.9.1+
Comment on attachment 379123 [details] [diff] [review]
patch v1.0

a191=beltzner
Attachment #379123 - Flags: approval1.9.1? → approval1.9.1+
(Assignee)

Comment 7

8 years ago
http://hg.mozilla.org/mozilla-central/rev/c300377fef84
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Whiteboard: [baking on trunk]
Attachment #379123 - Flags: approval1.9.1+ → approval1.9.1?
Comment on attachment 379123 [details] [diff] [review]
patch v1.0

Fine to have this bake on trunk, just switching the flag back so we can be clear about when we're happy to take this on branch.
Target Milestone: --- → mozilla1.9.2a1
Comment on attachment 379123 [details] [diff] [review]
patch v1.0

a191=shaver; please land ASAP
Attachment #379123 - Flags: approval1.9.1? → approval1.9.1+
(Assignee)

Comment 10

8 years ago
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/4e998d523e64
Keywords: fixed1.9.1
Whiteboard: [baking on trunk]
Marking verified fixed on trunk and 1.9.1 based on check-in and a green tree.
Status: RESOLVED → VERIFIED
Keywords: fixed1.9.1 → verified1.9.1
You need to log in before you can comment on or make changes to this bug.