494452 - [preview] "Search for addons" text is taken as vars

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Aakash Desai [:aakashd]]

Note: This works fine when a user clicks on the text field first (which will make it blank).

Steps to reproduce
1. Go to the URL
2. Click on the green" button on the search box in the new AMO without click in the text field.

Actual Results:
"Search for addons" taken as a parameter

Expected Results:
the parameter should not be taken and it isn't in the current AMO site.

Comment 1

[Wil Clouser [:clouserw]]

Just need to copy this to the amo2009 search element I'm guessing

Comment 2

[Les Orchard [:lorchard]]

Attachment: Use JS to insert instructional phrase, and remove it on submit or search field click

I couldn't find the JS handling this in the old layout, so I threw this together.  Without JS enabled, the search field should stay empty or populated with the previous search on search results page.  With JS enabled, an empty search field will get "search for add-ons", which will be deleted if the field is clicked or if the form is submitted.

Comment 3

[Wil Clouser [:clouserw]]

Comment on attachment 379234 [details] [diff] [review]
Use JS to insert instructional phrase, and remove it on submit or search field click

The old code is in mozilla.thtml on line 185 but if I remember correctly it's doing some crazy floating label stuff.

I'm r-ing this because it doesn't replace "search for add-ons" on blur if nothing else is entered.  I know it's picky.

Comment 4

[Les Orchard [:lorchard]]

Attachment: adaptation of original search label

Made a few tweaks from the original, hopefully this does it

Comment 5

[Les Orchard [:lorchard]]

checked in as r26449

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED -- I played with onblur() and it seems to do the right thing wrt onfocus() clearing the textfield and onblur() restoring the text, and the search query is correct (https://preview.addons.mozilla.org/en-US/firefox/search?q=&cat=all) per the testcase in comment 0.