494476 - In month/multiweek views, event boxes are misplaced by 1px to the left

Status: VERIFIED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Decathlon]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; it-IT; rv:1.9.0.10) Gecko/2009042316 Firefox/3.0.10
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1pre) Gecko/20090521 Lightning/1.0pre Shredder/3.0b3pre

In month view and multiweek view, every event boxes is misplaced to the left side of the day-box. With Sunbird\Lightning 1.0pre (Gecko 1.9) there are always two pixels to the left and three pixels to right, instead with Sb\Lg 0.9 the distance can change.
This behavior is a wanted workaround that allowed to build the month-multiweek views in Calendar 0.9. With bug 430382, attachment 331076 [details] [diff] [review] introduced a padding-right and a padding-bottom (1px) to calendar-month-day-box element in calendar-views.css file (see bug 430382 comment #31).
The reason was to avoid disappearing grid lines when window resizes caused by a specific bug of Gecko 1.8 but not present in Gecko 1.9 and later.

So, with Gecko 1.9.1, I think those two padding attributes can be removed from the css file.


Reproducible: Always

Steps to Reproduce:
1. create an event in month view


Actual Results:  
the event box has three pixels distance from the month grid to the right side and two pixels to the left side.


Expected Results:  
the event box should stay in the middle of the day box.

Comment 1

[Decathlon]

Attachment: remove two padding attributes

This patch fixes the issue removing two padding element in calendar-views.css.
I've tested  the absence of the bug that caused disappearing lines resizing the calendar view (resizing the window, today pane, left pane) and it seems everything Ok.
In the following screenshot, the month-view without and with the patch.

Comment 2

[Decathlon]

Attachment: screenshot with and without patch

Comment 3

[Martin Schröder [:mschroeder]]

Comment on attachment 379231 [details] [diff] [review]
remove two padding attributes

Looks good! r=mschroeder

Decathlon, how do the boxes of two events on the same day look like (bottom padding)?

Comment 4

[Decathlon]

Attachment: screenshot to show the bottom side

>Decathlon, how do the boxes of two events on the same day look like (bottom
>padding)?

On bottom side events boxes don't have any padding, and touch the grid line. If boxes are 1px from the bottom, without patch scroll bar appears (see attachment), with patch doesn't appear the scroll bar.
Don't know what's better.

Comment 5

[Martin Schröder [:mschroeder]]

(In reply to comment #4)
> On bottom side events boxes don't have any padding, and touch the grid line. If
> boxes are 1px from the bottom, without patch scroll bar appears (see
> attachment), with patch doesn't appear the scroll bar.
> Don't know what's better.

Go for checkin, imo! Philipp, does this need further UI inspection?

Comment 6

[Philipp Kewisch [:Fallen][☁️📆]]

No, go ahead.

Comment 7

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/858991e55c21

Comment 8

[Damian Szczepanik]

verified with
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.9pre) Gecko/20100305 Calendar/1.0b2pre

Comment 9

[Philipp Kewisch [:Fallen][☁️📆]]

These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".