494499 - maintenance.php script for tracking collection popularity

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Collections, defect)

Description

[Jeff Balogh (:jbalogh)]

Separating this from bug 493864.  We want to be able to sort by popularity weekly, monthly, and all-time.

Comment 1

[Jeff Balogh (:jbalogh)]

Attachment: script and db changes for tracking collection popularity

Comment 2

[Jeff Balogh (:jbalogh)]

Attachment: alter statements for collections table stats

Comment 3

[Justin Scott [:fligtar]]

$db->query() uses the slave db unless you pass in "true" as the second parameter to use the master. So any queries that need to write need to have true in them.

Comment 4

[Jeff Balogh (:jbalogh)]

Thanks justin.  There's an UPDATE with query on lines 290, 317, 358, 379, 391, probably more.  Are you saying that those are all not working?  Is there already a better function to use than query, or should I write one?

Comment 5

[Jeff Balogh (:jbalogh)]

Oh, it would be nice if this patch used better names than weeklydownloads and monthlydownloads since we're talking about subscribers.

Comment 6

[Justin Scott [:fligtar]]

I am just saying instead of doing $db->query("UPDATE"), just do $db->query("UPDATE", true) and everything will work fine. This is what's done in the other bin scripts.

Comment 7

[Wil Clouser [:clouserw]]

(In reply to comment #5)
> Oh, it would be nice if this patch used better names than weeklydownloads and
> monthlydownloads since we're talking about subscribers.

Why don't you call them something else then? Like weeklysubscribers and monthlysubscribers?

Comment 8

[Wil Clouser [:clouserw]]

Comment on attachment 380359 [details] [diff] [review]
script and db changes for tracking collection popularity

r+ if you get rid of the var_dump() and rename the columns

Comment 9

[Jeff Balogh (:jbalogh)]

Tracking weekly_subscribers and monthly_subscribers in r26543.

Comment 10

[Jeff Balogh (:jbalogh)]

Attachment: alter statements for collections table stats

Updated the column names.

Comment 11

[Fred Wenzel [:wenzel]]

The wiki page https://wiki.mozilla.org/Update:Developers/Database_Changes is sad if you ignore it.

Comment 12

[Jeff Balogh (:jbalogh)]

Too many things for me to remember!

Comment 13

[Wil Clouser [:clouserw]]

(In reply to comment #12)
> Too many things for me to remember!

Your brain is full of ridiculous git commands

Comment 14

[Stephen Donner [:stephend] Not actively reading bugmail]

removing "push-needed" from 105 AMO 5.0.6 bugs; filter on "I hate stephend!"