Closed
Bug 494503
Opened 15 years ago
Closed 15 years ago
The browser freezes with being loading a certain page with minimum fontsize higher than 14px.
Categories
(Core :: Layout: Floats, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: alice0775, Unassigned)
References
()
Details
(Keywords: hang, regression, testcase)
Attachments
(2 files)
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1pre) Gecko/20090522 Firefox/3.5.0 (.NET CLR 3.5.30729) Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090522 Minefield/3.6a1pre ID:20090522044436 When I set the minimum font size(like 18), the browser freezes with being loading a certain page. Not setting the minimum font size (none), the browser dows not freeze. Reproducible: Always Steps to Reproduce: 1. Start Minefield with new profile. 2. "Tools" > "Options..." > "Content" tab > (Font & Colors) "Advanced…" button 3. Minimum font size: set to 18 > OK > OK 4. GO URL Actual Results: The browser freezes with being loading a page. Expected Results: Should Not Freeze Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090522 Minefield/3.6a1pre ID:20090522044436 Regression range: Works fine: http://hg.mozilla.org/mozilla-central/rev/0f4de606acd7 Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090520 Minefield/3.6a1pre ID:20090520041818 Broken; http://hg.mozilla.org/mozilla-central/rev/d0ae0b099a40 Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090521 Minefield/3.6a1pre ID:20090521043940 Pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=0f4de606acd7&tochange=d0ae0b099a40 [More specific regression range]: Works fine: http://hg.mozilla.org/mozilla-central/rev/815856a7144b Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090520 Minefield/3.6a1pre ID:20090520052622 Broken: http://hg.mozilla.org/mozilla-central/rev/be75e40365ce Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090520 Minefield/3.6a1pre ID:20090520060031 Pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=815856a7144b&tochange=be75e40365ce Candidate for regression: Bug 25888 - inlines wrapping around floats only check top pixel of line for overlap (negative top margins or multiple floats) If Minimum font size: set to "none", the browser does not freeze, works fine.
Reporter | ||
Updated•15 years ago
|
Comment 1•15 years ago
|
||
It really needs to be 'minimum font-size 16px'. I tried with 12px (my normal set up) and 14px: no problems. Once I change to 16px the browser hangs immediately.
Updated•15 years ago
|
Component: General → Layout: Floats
Product: Firefox → Core
QA Contact: general → layout.floats
Comment 2•15 years ago
|
||
Sample taken while browser hangs. This is on 0S X 10.5.7. Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090522 Minefield/3.6a1pre
Updated•15 years ago
|
OS: Windows XP → All
Comment 3•15 years ago
|
||
Minimised from URL. This probably can be minimised further, but I got tired of hanging the browser :-)
Comment 4•15 years ago
|
||
There is no need to set a minimum font-size. Zooming in a couple of times with text-zoom is enough. In the testcase, there is a line 'height:18px'. When commenting that out the browser hangs on load, whatever the (text-)zoom factor or the minimum font-size is.
Updated•15 years ago
|
Flags: blocking1.9.2?
Updated•15 years ago
|
Summary: The browser freezes with being loading a certain page. → The browser freezes with being loading a certain page with minimum fontsize higher than 14px.
Comment 6•15 years ago
|
||
philippe, the sample looks like it was taken with a nightly, not a shark build or other build with symbols. :(
Comment 7•15 years ago
|
||
OK, on the original page with a debug build on Mac, if I make the min font-size be 18px I get an abort here: (gdb) frame 7 #7 0x131501e6 in nsBlockFrame::ReflowInlineFrames (this=0x2390d514, aState=@0xbffee2b0, aLine={mCurrent = 0x2390d818, mListLink = 0x2390d558}, aKeepReflowGoing=0xbffedfc4) at /Users/bzbarsky/mozilla/vanilla/mozilla/layout/generic/nsBlockFrame.cpp:3403 3403 NS_ABORT(); (gdb) list 3398 #ifdef DEBUG 3399 spins++; 3400 if (1000 == spins) { 3401 ListTag(stdout); 3402 printf(": yikes! spinning on a line over 1000 times!\n"); 3403 NS_ABORT(); 3404 } 3405 #endif roc, dbaron, you might be interested in this. ;)
Severity: normal → critical
Comment 8•15 years ago
|
||
(In reply to comment #6) > philippe, the sample looks like it was taken with a nightly, not a shark build > or other build with symbols. :( Yeah, I just catched what the build in front of me did... Are the 'firefox-3.6a1pre.en-US.mac-shark.dmg' anything useful in this (or similar) case ? http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-trunk/
Comment 9•15 years ago
|
||
Yes; those are the "shark builds" I mention in comment 6. Those will give you useful samples.
Is this trunk only, or is it also present in Firefox 3.5 builds?
Er, sorry, never mind... I see the regression range in comment 0, and agree this is likely to be the result of bug 25888.
Comment 12•15 years ago
|
||
I reported several bugs with the "yikes! spinning..." abort recently: bug 494332, bug 493910. Could this bug be related?
Yes.
Comment 14•15 years ago
|
||
(In reply to comment #11) > Er, sorry, never mind... I see the regression range in comment 0, and agree > this is likely to be the result of bug 25888. There is a similar hang reported in bug 494089 that I verified as being caused by bug 25888. Another commenter on that bug indicated the stack looks similar to the hang in this bug. That bug was easier to reproduce as it was not dependent on screen resolution, window size or font size, even though it was obviously a much more complicated page. I used that with hg bisect to identify changeset be75e40365ce from bug 25888 as the culprit.
This works for me, but it wouldn't surprise me if it's fixed by the patch I'm going to attach to bug 494332 shortly.
Comment 16•15 years ago
|
||
I've build the latest trunk today and the bug is gone. Thanks David.
Updated•15 years ago
|
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Flags: blocking1.9.2?
You need to log in
before you can comment on or make changes to this bug.
Description
•