Promo module on home page is too tall and no link to collection in promo module

VERIFIED FIXED in 5.0.6

Status

addons.mozilla.org Graveyard
Public Pages
P1
normal
VERIFIED FIXED
9 years ago
2 years ago

People

(Reporter: osunick, Assigned: rdoherty)

Tracking

unspecified
5.0.6

Details

Attachments

(1 attachment)

(Reporter)

Description

9 years ago
including radius, it should be about 105 px tall:
http://people.mozilla.org/~jscott/bandwagon/clearleft/v11/Home-Shopping.png

preview has it at 180 px tall.

Lots of extra white space and the module pushes too much content below the fold at 180px.  Truncate descriptions at 80 characters to make space.

Other thing missing- there should be a link to the collection using the collection's real name (not the placeholder set in the admin tool)

English text should be "View the <link><collection name> Collection</link>"
(Reporter)

Updated

9 years ago
OS: Mac OS X → All
Priority: -- → P1
Hardware: x86 → All
Target Milestone: --- → 5.0.6
(Reporter)

Updated

9 years ago
Blocks: 494519
This is all part of 491581.  I don't know why this would block 494519 so I'm removing that.
Assignee: nobody → rdoherty
(Assignee)

Comment 2

9 years ago
Created attachment 380550 [details] [diff] [review]
v1

First stab, asking Les to review as he wrote the first version of the collection promo controller code.

This also has a fix for bug 495356
Attachment #380550 - Flags: review?(lorchard)
(Assignee)

Comment 3

9 years ago
(In reply to comment #2)
> This also has a fix for bug 495356

Reason for this is the code change was so tiny I just did it with this patch. Normally wouldn't.
Attachment #380550 - Flags: review?(lorchard) → review+
Comment on attachment 380550 [details] [diff] [review]
v1

This works for me - but I think bigger changes for the collections promo box might be in store.

See: https://bugzilla.mozilla.org/show_bug.cgi?id=494862#c5

Not sure what to do about that, yet.
(Assignee)

Comment 5

9 years ago
r26778

For QA:
The height is as close as possible, it is still off by a few pixels.
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
I think we're happy with this on https://addons.mozilla.org/en-US/firefox/.

Verified FIXED.
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.