494512 - [silme] JarClient.get_l10npackage: don't close the jar-file if it was open before

Status: RESOLVED FIXED

(Mozilla Localizations :: Infrastructure, defect)

Description

[Adrian Kalla [:adriank]]

The current behavior, even if we didn't open a jar-file here:
http://hg.mozilla.org/users/zbraniecki_mozilla.com/silme/file/2af263121b1d/lib/silme/io/jar.py#l55
(because cls.zfile existed there already), is, that we close the file here:
http://hg.mozilla.org/users/zbraniecki_mozilla.com/silme/file/2af263121b1d/lib/silme/io/jar.py#l82
anyway.
The more convenient way would be to close it only, if it was opened in line 55.

Comment 1

[Adrian Kalla [:adriank]]

Attachment: patch v1

This patch adds a new boolean variable to know if the JAR-file was already open at beginning of the get_l10npackage method. If it wasn't open, the JAR-file will be closed before leaving get_l10npackage, otherwise it will remain open.

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 379902 [details] [diff] [review]
patch v1

I'm wondering how we failed to find it earlier especially since I'm pretty sure that _close_jar was tested against it.

Anyway, the patch seems good except that it does not apply against branch nor trunk.

Can you update the patch please?

Comment 3

[Adrian Kalla [:adriank]]

Attachment: patch updated to match current trunk

taking review from previous patch...

Comment 4

[Zibi Braniecki [:zbraniecki][:gandalf]]

Commited!

http://hg.mozilla.org/users/zbraniecki_mozilla.com/silme/rev/2d396cee08fa
http://hg.mozilla.org/users/zbraniecki_mozilla.com/silme/rev/c5ea47891e37