494538 - A page info dialog that is opened during private browsing stays open after leaving private browsing

Status: VERIFIED FIXED

(Firefox :: Private Browsing, defect)

Description

[John Nadratowski]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b4) Gecko/20090423 Firefox/3.5b4 (.NET CLR 3.5.30729)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b4) Gecko/20090423 Firefox/3.5b4 (.NET CLR 3.5.30729)

When opening a page info dialog during a private browsing session, after leaving the private browsing session the page info dialog stays open.

Reproducible: Always

Steps to Reproduce:
1.Open a private browsing session by either using the keyboard shortcut (CTRL+SHIFT+P) or by the menu item (Tools> Start Private Browsing)
2.Navigate to any webpage (it's happened with multiple webpages I have tried, every time
3.Left click on the button next to the address bar
4.A pop-up panel opens with miscellaneous page information, click on the More Information... button
5.A page info dialog pops-up
6.Re-focus the main firefox window and leave private browsing mode by either using the keyboard shortcut or the menu item
7.Private browsing mode closes, but the page info dialog opened during private browsing stays open
Actual Results:  
The private browsing session closes, but the page info dialog opened during private browsing stays open

Expected Results:  
When a private browsing session is closed, the page info dialog(s) opened during that session should close as well.

I haven't tried this with multiple page info dialogs open, that might be included in the formal testing.

A personal note:
This is my first bug submitted to any projects besides my own.  As a fellow developer, I hope this helps.  Firefox is a wonderful product, you guys rock!!!

Comment 1

[u88484]

Same thing with downloads and page source.

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

John: thanks very much for the thorough bug report. Very much appreciated, and yes, it helps a great deal. Well spotted!

Ehsan/Connor: what's the complexity of the fix here?

I'm not sure I'd block Firefox 3.5 on this, gonna mull that for a bit. Comment 1 gives me pause. Kurt: are you saying that the downloads window retains the information about files you downloaded during the private browsing session?

Comment 3

[(no longer active)]

(In reply to comment #2)
> Ehsan/Connor: what's the complexity of the fix here?

It should be pretty simple, considering the fact that we just need to close page info dialogs when transitioning in and out of the private browsing mode, but I'm not sure if you're willing to consider it for approval.  If needed, I can prepare a patch shortly.

> I'm not sure I'd block Firefox 3.5 on this, gonna mull that for a bit. Comment
> 1 gives me pause. Kurt: are you saying that the downloads window retains the
> information about files you downloaded during the private browsing session?

No, I think Kurt meant that the Downloads window remains open.  If it retains its content though it's a (possibly blocker) bug.  Kurt: care to clarify?

The view source windows are bug 462639 which has had a patch for quite a while waiting for review...

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Not blocking based on comment 3, but would likely approve a patch if one presented itself. 

Kurt: renominate if you meant that it was retaining information about the downloaded files after exiting Private Browsing

Comment 5

[(no longer active)]

Attachment: Patch (v1)

Trivial patch with an automated test.

Comment 6

[(no longer active)]

(In reply to comment #4)
> Kurt: renominate if you meant that it was retaining information about the
> downloaded files after exiting Private Browsing

Actually, Kurt: please file a new bug and nominate that one in case you see download information retained, as it's probably got nothing to do with this bug.

Comment 7

[u88484]

(In reply to comment #6)
> (In reply to comment #4)
> > Kurt: renominate if you meant that it was retaining information about the
> > downloaded files after exiting Private Browsing
> 
> Actually, Kurt: please file a new bug and nominate that one in case you see
> download information retained, as it's probably got nothing to do with this
> bug.
The download information is not retained so I'm not going to file a new bug.

Comment 8

[Mike Connor [:mconnor]]

Comment on attachment 379480 [details] [diff] [review]
Patch (v1)

Looks good, thanks.

Requesting 1.9.1, this should be very safe and fixes a bug that kinda sucks.

Comment 9

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/7575419419e0

Comment 10

[Marcia Knous [:marcia]]

Verified fixed on the trunk using Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2a1pre) Gecko/20090526 Minefield/3.6a1pre and Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090526 Minefield/3.6a1pre. The page info dialog opened in PB does not persist when exiting the mode. 

Apologies for missing this during PB testing, but I guess I should have factored in having various dialogs open when I exited PB mode. Thanks John for filing the bug as well, if you want a tshirt send me an email with your request and I will get one for you.

Comment 11

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 379480 [details] [diff] [review]
Patch (v1)

a191=beltzner

Comment 12

[(no longer active)]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/132c5742b7e9

Comment 13

[Aakash Desai [:aakashd]]

verified FIXED on Shiretoko:

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1pre) Gecko/20090528 Shiretoko/3.5pre ID:20090528045343