494542 - undoing multiline selection delete fails

Status: RESOLVED FIXED

(Skywriter Graveyard :: Editor, defect)

Description

[Alex Iskander]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_5_7; en-us) AppleWebKit/528.18.1 (KHTML, like Gecko) Version/4.0 Safari/528.17
Build Identifier: 7d58f6bc9828

Due to some "fixes" for tabmode that I made, it appears that undoing the deletion of multiline selections has broken.

Reproducible: Always

Steps to Reproduce:
1. Make a multi-line selection.
2. Press "Backspace."
3. Press Cmd/Ctrl-Z
Actual Results:  
Only un-deletes the first line of the portion deleted.

Expected Results:  
Undeletion of the entire portion deleted.

This is due to a lack of checking for definedness of an argument used in autoindentation. Because I was apparently not careful enough to prevent an API change, things broke. I have already made a one-line fix here:
http://bitbucket.org/alexi/bespin-fixes/changeset/1886886719b2/

Sorry about that. I will test more thoroughly in future.

Comment 1

[Gordon P. Hemsley [:GPHemsley]]

Don't worry. You're not the first one to cause problems with undo.

But this bug does currently exist, so marking as NEW.

Comment 2

[Alex Iskander]

I (think) I just pulled the tip into my patch:
http://bitbucket.org/alexi/bespin-fixes/overview/

If I understand hg right... I'm more used to bzr.

Comment 3

[Alex Iskander]

This fix has been pulled to tip.