494601 - When searching the Forum, there isnt a search box to search the forums again.

Status: RESOLVED WORKSFORME

(support.mozilla.org :: General, defect)

Description

[Ricardo Maçãs [:Ricmacas]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; pt-PT; rv:1.9.1b4) Gecko/20090423 Firefox/3.5b4 (.NET CLR 3.5.30729)
Build Identifier: 

When searching the forum, on the results page, you only get the option to search the KB.
This requires one of two things:
- Actually mentioning that the search box will search forums too, by relabeling the search box;
- Creating a box to search forums, again, with another keyword.

Reproducible: Always

Steps to Reproduce:
1.Search Forums on the Forum Homepage.
2.On the results page, there isnt another search box for searching the forums again (there is one, but its not labeled as such).
Actual Results:  
You only get the option to search the KB, using the search box actually gives you a Forum-KB search.

Expected Results:  
A forum search box.

Comment 1

[Paul Craciunoiu [:paulc]]

This is an easy fix. We should dump the following code into the search box:
---------
<div class="mod-searchlogoform">
<div class="mod-searchlogotitle">{tr}Search the Knowledge Base{/tr}</div>
{if $prefs.redirect_to_newsearch eq 'y' or $smarty.request.ns eq 'y'}<form action="/tiki-newsearch.php">{if $smarty.request.where}<input type="hidden" name="where" value="{$smarty.request.where}" />{/if}{else}
<form action="/tiki-searchresults.php">
{/if}
{if isset($currentLocale)}<input type="hidden" name="locale"
value="{$currentLocale}" />{/if}
<input id="fsearch" name="q" type="text" size="25" value="{$search_query|escape}"/>
<input id="searchsubmit" type="submit" name="sa" value="" alt="{tr}Search{/tr}"
title="{tr}Search{/tr}" />
</form>
</div>
------------------
At https://support.mozilla.com/tiki-admin_modules.php?um_edit=search#editcreate
Try this in action on stage. (see box contents: https://support-stage.mozilla.org/tiki-admin_modules.php?um_edit=search#editcreate)

Comment 2

[Paul Craciunoiu [:paulc]]

Laura, David: if it looks good on stage we can make the change anytime on prod.

Comment 3

[Paul Craciunoiu [:paulc]]

Chris, I think you can do this on production (anytime, but probably after push?). It's already done on staging.

I'll assign it to you as per our meeting today, I hope that's okay :)

Comment 4

[David Tenser [:djst]]

Chris, as always, be sure to test on stage first. Thanks!

Comment 5

[Chris Ilias [:cilias]]

After testing this, I think it would make search more confusing, because the search box still says "Search the Knowledge Base". Currently, the search box searches both KB and forum, and this edit changes it to search only the forum.

I think this change should be made in conjunction with or after changing the label.

Comment 6

[Chris Ilias [:cilias]]

While this bug was valid at the time it was reported, the ability to search again after searching the forums was added during the rewrite.