494619 - Add-ons for Firefox wrong color?

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Collections, defect)

Description

[Justin Scott [:fligtar]]

The "Firefox" part of the header was red before and now it's blue. Was this intentional as part of another bug? I think it should be red.

Also, in "Add-ons for Seamonkey" heading, Seamonkey should be SeaMonkey.

Comment 1

[Wil Clouser [:clouserw]]

Maybe we should replace the <img> with a <span> around Firefox and just give it a padding-left and a background image.

Comment 2

[Les Orchard [:lorchard]]

(In reply to comment #0)
> The "Firefox" part of the header was red before and now it's blue. Was this
> intentional as part of another bug? I think it should be red.

It was intentional in bug 494134 in-so-far as the red part was embedded in an image, and now it's text.  The design issues are bleeding into the localization issues.  I can try throwing another span or something into the localized string for the product title, but all localizers will need to carry that over.

> Also, in "Add-ons for Seamonkey" heading, Seamonkey should be SeaMonkey.

Separate bug from the color?  That's the name of the product in the localized strings - I can change English, but it's pretty inconsistent elsewhere:

site/app/locale/af/LC_MESSAGES/messages.po:5521:msgid "header_main_seamonkey_header"
site/app/locale/af/LC_MESSAGES/messages.po-5522-msgstr "Seamonkey Add-ons"
site/app/locale/ca/LC_MESSAGES/messages.po:4740:msgid "header_main_seamonkey_header"
site/app/locale/ca/LC_MESSAGES/messages.po-4741-msgstr "Complements del Seamonkey"
site/app/locale/cs/LC_MESSAGES/messages.po:4755:msgid "header_main_seamonkey_header"
site/app/locale/cs/LC_MESSAGES/messages.po-4756-msgstr "Doplňky Seamonkey"
site/app/locale/cy/LC_MESSAGES/messages.po:5186:msgid "header_main_seamonkey_header"

(In reply to comment #1)
> Maybe we should replace the <img> with a <span> around Firefox and just give it
> a padding-left and a background image.

Another separate bug? I spent a few hours trying to get a background image to work with the proper size, with RTL, and with the logo in different positions.  Never got it to work right, so I just went with the way clearleft had it.  Would rather not try that again, or let someone else try it.

Comment 3

[Wil Clouser [:clouserw]]

No need to fix "Seamonkey" everywhere - just in these strings.  I didn't merge these strings out to localizers yet so there is no conflicts or work on their part yet.

If you can add a quick span and we can close this bug, r=me.  I'm not worried about <img> vs. background-image for this.

Comment 4

[Les Orchard [:lorchard]]

I guess the other question is: If I make the text red for Firefox - what color should it be for each of the other apps?  Red also?

Comment 5

[Les Orchard [:lorchard]]

Attachment: quick patch to make product name colorable in title; Firefox color

This patch wraps a <strong> around the product name, which lets CSS apply a color.

One strange thing though, r26252 (Merge en-US -> all for 5.0.6) seems to have removed the strings used in bug 494134 (r26093).  This patch re-adds them with the <strong> tag changes.  Not sure what happened there, but hopefully this works

Comment 6

[Wil Clouser [:clouserw]]

Comment on attachment 379720 [details] [diff] [review]
quick patch to make product name colorable in title; Firefox color

Works for me.  They were removed because I didn't want to merge them out to localizers yet because I knew this bug wasn't fixed.

Comment 7

[Les Orchard [:lorchard]]

r26354

Comment 8

[Justin Scott [:fligtar]]

Sorry, I probably should have given the color when I opened this bug, but the color should be #D64203. It's what Clearleft used and is the official color here: http://www.mozilla.com/en-US/about/logo/style.html

Comment 9

[Les Orchard [:lorchard]]

tweaked in r26369.  strange thing was, I used digital color meter on OS X to pick the color from the old image.  wonder why that was different?

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://preview.addons.mozilla.org/en-US/firefox/.