494628 - Crash when trying to file a bug in a closed product

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Frédéric Buclin]

Can't locate object method "disallow_new" via package "Bugzilla::Product" at Bugzilla/User.pm line 727.
 at Bugzilla/User.pm line 727
	Bugzilla::User::can_enter_product('Bugzilla::User=HASH(0xaee8990)', 'TestProduct', 1) called at /var/www/html/bugzilla-pg/enter_bug.cgi line 164


There are still some instances of disallow_new in the Bugzilla code:

./Bugzilla/User.pm 731:
    elsif ($product->disallow_new) {

./template/en/default/bug/field.html.tmpl 143:
    || (field.name == "product" && legal_value.disallow_new)

./template/en/default/admin/components/confirm-delete.html.tmpl 86:
  <TD VALIGN="top">[% IF product.disallow_new %]Yes[% ELSE %]No[% END %]</td>

Comment 1

[Greg Hendricks]

Attachment: V1

Comment 2

[Greg Hendricks]

Attachment: V2

Comment 3

[Frédéric Buclin]

Comment on attachment 379707 [details] [diff] [review]
V2

>Index: template/en/default/admin/components/confirm-delete.html.tmpl

>   <TD VALIGN="top">Closed for [% terms.bugs %]:</TD>
>-  <TD VALIGN="top">[% IF product.disallow_new %]Yes[% ELSE %]No[% END %]</td>
>+  <TD VALIGN="top">[% IF product.is_active %]No[% ELSE %]Yes[% END %]</td>

The logic must be changed to match what editproducts.cgi uses, i.e. "Open for new bugs" rather than "Closed for new bugs".



>Index: template/en/default/bug/field.html.tmpl

>+                       || (field.name == "product" && legal_value.is_active == 0)

Nit: it's better to write !legal_value.is_active.



>Index: Bugzilla/User.pm

>+    elsif ($product->is_active == 0) {

Nit: same here: elsif (!$product->is_active). So we don't care if ->is_active is 0, undefined or "".

Comment 4

[Greg Hendricks]

Attachment: V3

Comment 5

[Greg Hendricks]

Attachment: V4

Comment 6

[Frédéric Buclin]

Comment on attachment 379710 [details] [diff] [review]
V4

r=LpSolit

Comment 7

[Greg Hendricks]

    Checking in Bugzilla/User.pm;
    /cvsroot/mozilla/webtools/bugzilla/Bugzilla/User.pm,v  <--  User.pm
    new revision: 1.189; previous revision: 1.188
    done
    Checking in template/en/default/admin/components/confirm-delete.html.tmpl;
    /cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/components/confirm-delete.html.tmpl,v  <--  confirm-delete.html.tmpl
    new revision: 1.13; previous revision: 1.12
    done
    Checking in template/en/default/bug/field.html.tmpl;
    /cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/field.html.tmpl,v  <--  field.html.tmpl
    new revision: 1.27; previous revision: 1.26