Closed Bug 494655 Opened 11 years ago Closed 11 years ago

Refresh flexible space icon on OS X

Categories

(Toolkit :: Themes, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla1.9.2a1

People

(Reporter: faaborg, Assigned: ehsan)

Details

(Keywords: fixed1.9.1, Whiteboard: [icon-3.5] [icon-complete])

Attachments

(3 files)

Need to do an image drop and switch the file name from .gif to .png in all places that reference the current image.
Attached image New spring
This file needs to replace the file at /source/toolkit/themes/pinstripe/global/toolbar/spring.gif
Whiteboard: [icon-3.5] [icon-complete]
Attached patch Patch (v1)Splinter Review
Assignee: nobody → ehsan.akhgari
Status: NEW → ASSIGNED
Attachment #379414 - Flags: review?(gavin.sharp)
Attachment #379414 - Flags: approval1.9.1?
I don't think we want to remove existing image files right before RC.
spring.gif exists only in pinstripe. Anyone relying on it is already broken.
Component: Theme → Themes
Product: Firefox → Toolkit
QA Contact: theme → themes
(In reply to comment #4)
> spring.gif exists only in pinstripe.

Scratch that, winstripe has an obsolete spring.gif on 1.9.1. Gnomestripe doesn't have it, and of course third-party themes aren't guaranteed to have it.
More developers realizing that their reference is bogus == good, imho.
>More developers realizing that their reference is bogus == good, imho.

A last minute switch is kind of a mean way to teach them though.  Can we both replace for our purposes and also package the other icon so we don't break any third party use?
Comment on attachment 379414 [details] [diff] [review]
Patch (v1)

This can land on trunk to bake once reviewed.
Attachment #379414 - Flags: review?(gavin.sharp) → review?(dao)
Comment on attachment 379414 [details] [diff] [review]
Patch (v1)

Please do remove spring.gif on trunk and leave it on branch.
Attachment #379414 - Flags: review?(dao) → review+
(In reply to comment #8)
> (From update of attachment 379414 [details] [diff] [review])
> Please do remove spring.gif on trunk and leave it on branch.

Should we continue to package it on branch as well?
I don't think so, but Gavin says we should.
http://hg.mozilla.org/mozilla-central/rev/c569f6c33f05
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
Attachment #379414 - Flags: approval1.9.1?
Attached patch 1.9.1 PatchSplinter Review
Leaving spring.gif alone on 1.9.1...
Attachment #380058 - Flags: approval1.9.1?
Attachment #380058 - Flags: approval1.9.1? → approval1.9.1+
You need to log in before you can comment on or make changes to this bug.