Refresh flexible space icon on OS X

RESOLVED FIXED in mozilla1.9.2a1

Status

()

RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: faaborg, Assigned: Ehsan)

Tracking

({fixed1.9.1})

Trunk
mozilla1.9.2a1
x86
Mac OS X
fixed1.9.1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [icon-3.5] [icon-complete])

Attachments

(3 attachments)

(Reporter)

Description

10 years ago
Need to do an image drop and switch the file name from .gif to .png in all places that reference the current image.
(Reporter)

Comment 1

10 years ago
Created attachment 379399 [details]
New spring

This file needs to replace the file at /source/toolkit/themes/pinstripe/global/toolbar/spring.gif
(Reporter)

Updated

10 years ago
Whiteboard: [icon-3.5] [icon-complete]
(Assignee)

Comment 2

10 years ago
Created attachment 379414 [details] [diff] [review]
Patch (v1)
Assignee: nobody → ehsan.akhgari
Status: NEW → ASSIGNED
Attachment #379414 - Flags: review?(gavin.sharp)
Attachment #379414 - Flags: approval1.9.1?
I don't think we want to remove existing image files right before RC.

Comment 4

10 years ago
spring.gif exists only in pinstripe. Anyone relying on it is already broken.

Updated

10 years ago
Component: Theme → Themes
Product: Firefox → Toolkit
QA Contact: theme → themes

Comment 5

10 years ago
(In reply to comment #4)
> spring.gif exists only in pinstripe.

Scratch that, winstripe has an obsolete spring.gif on 1.9.1. Gnomestripe doesn't have it, and of course third-party themes aren't guaranteed to have it.
More developers realizing that their reference is bogus == good, imho.
(Reporter)

Comment 6

10 years ago
>More developers realizing that their reference is bogus == good, imho.

A last minute switch is kind of a mean way to teach them though.  Can we both replace for our purposes and also package the other icon so we don't break any third party use?
Comment on attachment 379414 [details] [diff] [review]
Patch (v1)

This can land on trunk to bake once reviewed.
Attachment #379414 - Flags: review?(gavin.sharp) → review?(dao)

Comment 8

10 years ago
Comment on attachment 379414 [details] [diff] [review]
Patch (v1)

Please do remove spring.gif on trunk and leave it on branch.
Attachment #379414 - Flags: review?(dao) → review+
(Assignee)

Comment 9

10 years ago
(In reply to comment #8)
> (From update of attachment 379414 [details] [diff] [review])
> Please do remove spring.gif on trunk and leave it on branch.

Should we continue to package it on branch as well?
I don't think so, but Gavin says we should.
(Assignee)

Comment 11

10 years ago
http://hg.mozilla.org/mozilla-central/rev/c569f6c33f05
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
(Assignee)

Updated

10 years ago
Attachment #379414 - Flags: approval1.9.1?
(Assignee)

Comment 12

10 years ago
Created attachment 380058 [details] [diff] [review]
1.9.1 Patch

Leaving spring.gif alone on 1.9.1...
Attachment #380058 - Flags: approval1.9.1?
Attachment #380058 - Flags: approval1.9.1? → approval1.9.1+
You need to log in before you can comment on or make changes to this bug.