Closed
Bug 494655
Opened 15 years ago
Closed 15 years ago
Refresh flexible space icon on OS X
Categories
(Toolkit :: Themes, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9.2a1
People
(Reporter: faaborg, Assigned: ehsan.akhgari)
Details
(Keywords: fixed1.9.1, Whiteboard: [icon-3.5] [icon-complete])
Attachments
(3 files)
239 bytes,
image/png
|
Details | |
3.61 KB,
patch
|
dao
:
review+
|
Details | Diff | Splinter Review |
3.68 KB,
patch
|
beltzner
:
approval1.9.1+
|
Details | Diff | Splinter Review |
Need to do an image drop and switch the file name from .gif to .png in all places that reference the current image.
Reporter | ||
Comment 1•15 years ago
|
||
This file needs to replace the file at /source/toolkit/themes/pinstripe/global/toolbar/spring.gif
Reporter | ||
Updated•15 years ago
|
Whiteboard: [icon-3.5] [icon-complete]
Assignee | ||
Comment 2•15 years ago
|
||
Assignee: nobody → ehsan.akhgari
Status: NEW → ASSIGNED
Attachment #379414 -
Flags: review?(gavin.sharp)
Attachment #379414 -
Flags: approval1.9.1?
Comment 3•15 years ago
|
||
I don't think we want to remove existing image files right before RC.
Comment 4•15 years ago
|
||
spring.gif exists only in pinstripe. Anyone relying on it is already broken.
Updated•15 years ago
|
Component: Theme → Themes
Product: Firefox → Toolkit
QA Contact: theme → themes
Comment 5•15 years ago
|
||
(In reply to comment #4) > spring.gif exists only in pinstripe. Scratch that, winstripe has an obsolete spring.gif on 1.9.1. Gnomestripe doesn't have it, and of course third-party themes aren't guaranteed to have it. More developers realizing that their reference is bogus == good, imho.
Reporter | ||
Comment 6•15 years ago
|
||
>More developers realizing that their reference is bogus == good, imho.
A last minute switch is kind of a mean way to teach them though. Can we both replace for our purposes and also package the other icon so we don't break any third party use?
Comment 7•15 years ago
|
||
Comment on attachment 379414 [details] [diff] [review] Patch (v1) This can land on trunk to bake once reviewed.
Attachment #379414 -
Flags: review?(gavin.sharp) → review?(dao)
Comment 8•15 years ago
|
||
Comment on attachment 379414 [details] [diff] [review] Patch (v1) Please do remove spring.gif on trunk and leave it on branch.
Attachment #379414 -
Flags: review?(dao) → review+
Assignee | ||
Comment 9•15 years ago
|
||
(In reply to comment #8) > (From update of attachment 379414 [details] [diff] [review]) > Please do remove spring.gif on trunk and leave it on branch. Should we continue to package it on branch as well?
Comment 10•15 years ago
|
||
I don't think so, but Gavin says we should.
Assignee | ||
Comment 11•15 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/c569f6c33f05
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
Assignee | ||
Updated•15 years ago
|
Attachment #379414 -
Flags: approval1.9.1?
Assignee | ||
Comment 12•15 years ago
|
||
Leaving spring.gif alone on 1.9.1...
Attachment #380058 -
Flags: approval1.9.1?
Updated•15 years ago
|
Attachment #380058 -
Flags: approval1.9.1? → approval1.9.1+
Comment 13•15 years ago
|
||
Comment on attachment 380058 [details] [diff] [review] 1.9.1 Patch a191=beltzner
Assignee | ||
Comment 14•15 years ago
|
||
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/e3cc670e1c64
Keywords: fixed1.9.1
You need to log in
before you can comment on or make changes to this bug.
Description
•