494656 - Notification bar icon: popups blocked

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Alex Faaborg [:faaborg] (Firefox UX)]

Assuming that no other notification bars are referencing /source/browser/themes/pinstripe/browser/Info.png

we need to update this icon to the new pop-ups blocked image for OS X.  Currently these is a Firefox 2 icon and really clashes with the new yellow bar added in Firefox 3.

(info.png isn't the best name for popups blocked, but this is the convention being used by winstripe and gnomestrip, we should update all three at the same time later).

Comment 1

[Alex Faaborg [:faaborg] (Firefox UX)]

Attachment: New popups blocked icon (Info.png)

Designed to match the style of other notification bar icons on OS X

Comment 2

[Alex Faaborg [:faaborg] (Firefox UX)]

Note bug 494657 for updating the default icons for various types of notification bars on OS X (error, warning, question, information).

Comment 3

[Dão Gottwald [:dao]]

Winstripe and Gnomestripe get this wrong, it's not just used for popups-blocked notifications.

Comment 4

[(no longer active)]

So, we need to add a new icon to pinstripe, right?

Comment 5

[Dão Gottwald [:dao]]

That won't help, since the popup-blocked notification will still use Info.png. We should fix the API to accept a class name rather than an icon location...

Comment 6

[Alex Faaborg [:faaborg] (Firefox UX)]

>Winstripe and Gnomestripe get this wrong, it's not just used for popups-blocked
>notifications.

Really? I guess I haven't run into that.  What other bars are displaying the pop-up blocked icon (Info.png)?

Comment 7

[Dão Gottwald [:dao]]

images-blocked, refresh-blocked, offline-app-usage and offline-app-requested-*.

Comment 8

[Alex Faaborg [:faaborg] (Firefox UX)]

>images-blocked, refresh-blocked, offline-app-usage and offline-app-requested-*.

The icon sort of works for the first two, and while it doesn't make any sense at all for the later two, they are rather rare.  Perhaps drop the icon in now so that we can remove the Firefox 2 blue one, and then take care of the rest in a follow up bug?

Comment 9

[Dão Gottwald [:dao]]

Comment on attachment 379400 [details]
New popups blocked icon (Info.png)

Sure, since winstripe and gnomestripe already do it this way...

Comment 10

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/b2c44b35b8d4

Comment 11

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 379400 [details]
New popups blocked icon (Info.png)

a191=beltzner

Comment 12

[(no longer active)]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/3546f359f2b5

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified fixed with:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090525 Minefield/3.6a1pre ID:20090525031110

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1pre) Gecko/20090525 Shiretoko/3.5pre ID:20090525031033