494658 - Refresh new tab icon on Windows

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Alex Faaborg [:faaborg] (Firefox UX)]

Image drop in for the new tab button on XP and Vista

Comment 1

[Alex Faaborg [:faaborg] (Firefox UX)]

files will be posted tomorrow, need to get some sleep

Comment 2

[Alex Faaborg [:faaborg] (Firefox UX)]

Attachment: newtab.png

each image has a 18x18 area to accommodate the glow effect for the hit state.

Comment 3

[Alex Faaborg [:faaborg] (Firefox UX)]

Attachment: newtab-aero.png

Comment 4

[u88484]

Alex, will this miniature icon only be shown when the new tab button is "docked" with the tab strip right scroll button and the all tabs button?  If not, it is way too tiny.  Also, I think you uploaded the same icon twice.  I can't tell even a slight difference between the two when the images are opened up in two different tabs and I switch between them.

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

(this has my pre-approval to land on mozilla-central once reviewed, please nominate for a191 when that happens)

Comment 6

[Alex Faaborg [:faaborg] (Firefox UX)]

>I think you uploaded the same icon twice.  I
>can't tell even a slight difference between the two when the images are opened
>up in two different tabs and I switch between them.

The only difference is that the aero icons use a slightly darker shade of blue on the hit state.  It's more obvious when they are enlarged.

>If not, it is way too tiny.

This is the intended size for both placements.  Discoverability is a zero sum game, using size and color everywhere just gives you a time square effect where you end up seeing everything and nothing.  I think the increased whitespace around the way too tiny icon actually makes the plus symbol a bit more prominent.

Comment 7

[Alex Faaborg [:faaborg] (Firefox UX)]

Attachment: Quick mockup of the non-overflow state

Comment 8

[Alex Faaborg [:faaborg] (Firefox UX)]

We should probably block on this image swap since I don't actually know where the current images came from, and we may not have the rights to use them. (are they famfamfam? bug 424877)

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

Who checked the files in? Do they know the provenance?

Comment 10

[Dão Gottwald [:dao]]

The plus sign is stolen from Toolbar.png's New Tab icon.

Comment 11

[Dão Gottwald [:dao]]

Attachment: patch

Comment 12

[u88484]

(In reply to comment #6)
> This is the intended size for both placements.  Discoverability is a zero sum
> game, using size and color everywhere just gives you a time square effect where
> you end up seeing everything and nothing.  I think the increased whitespace
> around the way too tiny icon actually makes the plus symbol a bit more
> prominent.
(In reply to comment #7)
> Created an attachment (id=380313) [details]
> Quick mockup of the non-overflow state
I stand corrected.  It looks pretty good.

Comment 13

[Mike Beltzner [:beltzner, not reading bugmail]]

Not blocking, but a191.

Comment 14

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/e44d9c0f4805

Comment 15

[Dão Gottwald [:dao]]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/57be2b246af5

Comment 16

[Aakash Desai [:aakashd]]

verified FIXED on 

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1pre) Gecko/20090601 Shiretoko/3.5pre ID:20090601044045

and

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090601 Minefield/3.6a1pre ID:20090601041706

Comment 17

[Andrew Cook]

The new "new tab" button seems visually dissonant to me, debossed when the tabs, close buttons, old tabbar arrows, and tab list button are all embossed. Was this dissonant effect intended?

Comment 18

[u88484]

(In reply to comment #17)
> The new "new tab" button seems visually dissonant to me, debossed when the
> tabs, close buttons, old tabbar arrows, and tab list button are all embossed.
> Was this dissonant effect intended?
See bug 495617, bug 495631, and bug 495668