494659 - Refresh new tab icon on OS X

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Alex Faaborg [:faaborg] (Firefox UX)]

Image drop in bug for updating the new tab icon on OS X

Comment 1

[Alex Faaborg [:faaborg] (Firefox UX)]

Attachment: Refreshed new tab button for OS X

This file should replace the file at /source/browser/themes/pinstripe/browser/tabbrowser/newtab.png

Also, this file now includes states for (in order) normal, hover, hit.

Comment 2

[Dão Gottwald [:dao]]

Can the transparent padding be removed?

Comment 3

[Alex Faaborg [:faaborg] (Firefox UX)]

>Can the transparent padding be removed?

I'm not entirely sure what the question is, but sure :)  Do you mean editing the file, or just specifying a smaller image region?  Really either is fine.

Comment 4

[Dão Gottwald [:dao]]

Yes, I mean getting rid of it in the file. If we just specify a smaller region, editing the file later on and adding stuff to the area that has been cut off would lead to unexpected results.

Comment 5

[Markus Stange [:mstange]]

Hmm, there doesn't seem to be any unused padding in the hit state - the glow fills the whole area. And it even extends a little into to hover state... but I think that's only noticeable with a color picking tool.

Comment 6

[Dão Gottwald [:dao]]

Well, at least, there's more padding on the bottom than on the top. That doesn't seem to make sense.

Comment 7

[Alex Faaborg [:faaborg] (Firefox UX)]

Attachment: Cropped newtab.png

Equal padding on the top and bottom.

Comment 8

[Dão Gottwald [:dao]]

The icon for each state should be square, right? They are 18px wide, but 21px high. So the the padding is still off, both if you compare vertical to horizontal and top to bottom padding. The former is probably bad for the height of the tab bar, and the latter is bad for the vertical alignment.

Comment 9

[Alex Faaborg [:faaborg] (Firefox UX)]

I cropped to the size of the glow, does it have to be square (or smaller) to avoid breaking the tab strip?  If so let me know and I will resize, otherwise let's get this in before the RC freeze.

Comment 10

[Alex Faaborg [:faaborg] (Firefox UX)]

Attachment: Cropped cropped newtab.png

The images are 18x20, and states are:

normal / hover / hit

Comment 11

[Dão Gottwald [:dao]]

Attachment: patch

Comment 12

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 380592 [details] [diff] [review]
patch

a191=beltzner

Comment 13

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/75eb0b1d976d

Comment 14

[Dão Gottwald [:dao]]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/5f85a915fade

Comment 15

[Aakash Desai [:aakashd]]

verified FIXED on builds:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090602 Minefield/3.6a1pre ID:20090602050429

and

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1pre) Gecko/20090602 Shiretoko/3.5pre ID:20090602031310