494693 - visibility attribute ignored in nsIX509Cert2.idl

Status: RESOLVED INCOMPLETE

(Core Graveyard :: Security: UI, defect)

Description

[timeless]

../../../../dist/include/nsIX509Cert2.h:22: warning: ‘CERTCertificate’: visibility attribute ignored because it
../../../../dist/include/certt.h:72: warning: conflicts with previous declaration here

Comment 1

[timeless]

Attachment: patch

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 379458 [details] [diff] [review]
patch

I'm not sure why you want my review here?

Comment 3

[Kai Engert [:KaiE:]]

I don't understand why you need this change.

- typedef struct CERTCertificateStr CERTCertificate;
+ typedef NS_VISIBILITY_DEFAULT struct CERTCertificateStr CERTCertificate;


From NSS header file certt.h:

typedef struct CERTCertificateStr                CERTCertificate;


cc'ing Wan-Teh who knows a lot about these low level C flags.

Comment 4

[Wan-Teh Chang]

I am not familiar with NS_VISIBILITY_DEFAULT when it is applied to a type.
I know what it means when it is applied to a function.

I searched for NS_VISIBILITY_DEFAULT in mozilla-central but didn't find
any other example of the change that timeless suggested:
http://mxr.mozilla.org/mozilla-central/search?string=NS_VISIBILITY_DEFAULT

timeless, could you explain your proposed patch or give an example?  Thanks.

Comment 5

[Kai Engert [:KaiE:]]

Comment on attachment 379458 [details] [diff] [review]
patch

r- because we don't understand why the change is necessary

Comment 6

[Kai Engert [:KaiE:]]

incomplete