494724 - No "MozMill" in Sunbird 1.0pre "Tools" menu after install

Status: RESOLVED FIXED

(Testing Graveyard :: Mozmill, defect, P1)

Description

[gekacheka]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1pre) Gecko/20090524 Shiretoko/3.5pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1pre) Gecko/20090524 Calendar/1.0pre

After installing a MozMill xpi into a Sunbird 1.0pre nightly,
"MozMill" does not appear in the Sunbird "Tools" menu.


Reproducible: Always

Steps to Reproduce:
1. Install the mozmill-1.1 xpi into Sunbird 1.0pre nightly
  (Tools / Add-ons / Extensions / Install)
  ftp://ftp.mozilla.org/pub/mozilla.org/calendar/sunbird/nightly/latest-trunk/  
  https://addons.mozilla.org/en-US/sunbird/addon/9018
2. Restart Sunbird

Actual Results:  
The Sunbird 'Tools' menu is unchanged.

Expected Results:  
MozMill appears in the Sunbird 'Tools' menu.

Reason: The menu was moved to sunbird.jar (bug 290747).
Repair: add sunbird.jar to the chrome.manifest

Comment 1

[gekacheka]

Attachment: patch v1: add chrome://sunbird/ to chrome manifest

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Probably it would be better to ask Mikeal, but Clint knows Sunbird better. So Mikeal, could this be implemented as given by the proposed patch?

Comment 3

[cmtalbert]

Comment on attachment 379495 [details] [diff] [review]
patch v1: add chrome://sunbird/ to chrome manifest

Gekacheka! Nice to see you again. Thanks for the patch.  Do you need me to check this in for you?

r=ctalbert

Comment 4

[Mikeal Rogers [:mikeal] (mrogers@)]

Commited r466

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Gekacheka, can you confirm that it is working now with the latest Mozmill trunk? Please mark it as verified fixed. And thanks for the patch!