494740 - All shell script phases should echo what they're doing

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: echo, echo, do I hear an echo?

Sprinkles echos in the CaminoApp, CaminoStaticApp, and General.prefPane shell script phases.  The Sparkle lproj stripping and framework headers stripping already echo.

Comment 2

[Stuart Morgan]

Comment on attachment 379521 [details] [diff] [review]
echo, echo, do I hear an echo?

> echo "Library and framework copy phase must take
> place before linking."

This sounds like an error message as phrased; change it to "Forcing library and framework copy phase to happen before linking."

sr=smorgan with that change.

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

And, uh, you were right last night about that phase; somehow we were getting lucky, since I don't think $(WRAPPRE_NAME) is valid variable.  I've fixed that locally along with comment 2.

Comment 4

[Stuart Morgan]

Oops :( Although unless the output path is wrong too it should still run before linking, it just wouldn't be guaranteed to run after Breakpad was built.

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Landed on cvs trunk, with comment 2 and comment 3 addressed.