494759 - Adding new "Compatible Applications" then removing it is broken

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[Jesper Hansen]

To get to the affected page:
1. Developer Tools
2. When looking at the projects, select "Versions and Files" on a random project
3. Select a version. ie. "Version 0.1"
4. In "Compatible Applications" section.

Now to reproduce:
1. Press "Add New Application"
2. Select something from the list, doesn't matter what.
3. Press the red icon at the item you just added.

Result:
1. Every item in "Compatible Applications" gets removed.
2. The text "You have unsaved changes. Compatibility will not be deleted until you click Update Version below." shows up in the section "Compatible Applications".
3. The text "You have unsaved changes. Files will not be deleted until you click Update Version below." shows up in the section "File Information"

Expected result:
1. Only the affected item should get removed


Note that removing existing items from the list does work as expected.

Comment 1

[RJ Walsh [:rjwalsh]]

Attachment: Fix

Comment 2

[Wil Clouser [:clouserw]]

I noticed the "you have unsaved changes" message doesn't appear any more.  Is that an easy fix?

Comment 3

[RJ Walsh [:rjwalsh]]

Fixed in r49359, with fix from comment #2

Comment 4

[Jesper Hansen]

Could you fix the patch file as well here?

Comment 5

[RJ Walsh [:rjwalsh]]

Attachment: Fix (from commit)