494862 - [JS-disabled] Home page doesn't degrade gracefully with JavaScript disabled.

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Because it relies on JavaScript, the "Browse Add-ons" pane doesn't switch tabs when it's disabled.

This was, thankfully, implemented with JS disabled in the Collections management view.

Comment 1

[Wil Clouser [:clouserw]]

Les did the front page so he knows this best

Comment 2

[Les Orchard [:lorchard]]

Attachment: Switching to page refresh for addon browse panes on home page

Revised the addons listing on home page to work without JS on page refresh.  This should also satisfy the page size concern of bug 493814, though doesn't use any AJAX.  Not sure if this makes that harder

Comment 3

[Wil Clouser [:clouserw]]

Comment on attachment 380479 [details] [diff] [review]
Switching to page refresh for addon browse panes on home page

Nice work.  This makes the front page smaller too.

Comment 4

[Les Orchard [:lorchard]]

checked in as r26604

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Post-fix screenshot

Les, what do we want to do about this?

Comment 6

[Wil Clouser [:clouserw]]

(In reply to comment #5)
> Created an attachment (id=380576) [details]
> Post-fix screenshot
> 
> Les, what do we want to do about this?

Is there a way to reproduce that?

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #6)
> (In reply to comment #5)
> > Created an attachment (id=380576) [details] [details]
> > Post-fix screenshot
> > 
> > Les, what do we want to do about this?
> 
> Is there a way to reproduce that?

That's just with JavaScript disabled.

Comment 8

[Wil Clouser [:clouserw]]

reopening for the JS disabled case

Comment 9

[Les Orchard [:lorchard]]

Huh.  That's not the "Browse Addons" pane, that's the collections promo box.  Not really sure what to do with it, since I don't think it was built to accommodate disabled JS at all.  I doubt it would be a quick fix. :(

Comment 10

[Les Orchard [:lorchard]]

Changing the bug title, since it looks like the scope of the JS disabled stuff is growing

Comment 11

[Wil Clouser [:clouserw]]

I'd be fine if it just showed the first pane with no tabs.  Can we just display:none all that stuff?

Comment 12

[Les Orchard [:lorchard]]

Hmm... I'm looking for the commit that fixed it (not one of mine), but it looks like the non-JS home page works now on preview.  At least, in so far as all the slider segments are now laid out down the page.

Comment 13

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #12)
> Hmm... I'm looking for the commit that fixed it (not one of mine), but it looks
> like the non-JS home page works now on preview.  At least, in so far as all the
> slider segments are now laid out down the page.

Yeah, this now looks fine to me, again -- thanks!

Les, I think we can re-resolve this.

Comment 14

[Les Orchard [:lorchard]]

Aiight.  Closing this one

Comment 15

[Wil Clouser [:clouserw]]

self healing CSS? best monday ever

Comment 16

[Stephen Donner [:stephend] Not actively reading bugmail]

zomg