Picking this up.
Assignee: nobody → fwenzel
Hardware: x86 → All
(In reply to comment #1) > Picking this up. It was the sexy in the summary, wasn't it? <3
Oh, you know me so well, Stephen ;)
Created attachment 380227 [details] [diff] [review] Patch, rev. 1 I hope I win the price for the most ugly code removed in one day with this one ;) This contains the reskin that I made for the version history page, but I also had to redo the "latest compatible version" detection which was majorly broken. As a side effect, this also fixes bug 475825. I'll attach two example screenshots as well, so you can see what you *should* be seeing. QA: That's for you, later, also.
By the way: The patch contains two little png icons, so you want to use `git apply` to apply the patch.
omg That said, there are no images in the patch. Did you --binary it?
Created attachment 380277 [details] [diff] [review] Patch, rev. 2 I forgot the --binary flag, thanks!
Comment on attachment 380277 [details] [diff] [review] Patch, rev. 2 This touches a lot of code so it has the potential to break stuff. It WFM in my tests though, so I'll r+. The page looks good.
Attachment #380277 - Flags: review?(clouserw) → review+
r26542. Agreed, let's hope it didn't break anything more horribly than it was broken before. I made sure though that the install buttons still look reasonable in other places, after I removed the hideous version history hack from it.
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
The above URL has a self-linking breadcrumb :-(
Where else would the last one point?
(In reply to comment #13) > Where else would the last one point? Nowhere -- it's redundant.
Removed in r26548. NB: The string it used ("version history with change logs") was present on the old page and is now gone from the page.
Thanks, Fred -- this makes the page consistent with the other places we're using the breadcrumb. Verified FIXED
Status: RESOLVED → VERIFIED
removing "push-needed" from 105 AMO 5.0.6 bugs; filter on "I hate stephend!"
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.