494866 - Bring the AMO2009/ClearLeft sexy back to the Version History page

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Word.

Comment 1

[Fred Wenzel [:wenzel]]

Picking this up.

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #1)
> Picking this up.

It was the sexy in the summary, wasn't it? <3

Comment 3

[Fred Wenzel [:wenzel]]

Oh, you know me so well, Stephen ;)

Comment 4

[Fred Wenzel [:wenzel]]

Attachment: Patch, rev. 1

I hope I win the price for the most ugly code removed in one day with this one ;)

This contains the reskin that I made for the version history page, but I also had to redo the "latest compatible version" detection which was majorly broken. As a side effect, this also fixes bug 475825.

I'll attach two example screenshots as well, so you can see what you *should* be seeing. QA: That's for you, later, also.

Comment 5

[Fred Wenzel [:wenzel]]

Attachment: Screenshot: Regular behavior

Comment 6

[Fred Wenzel [:wenzel]]

Attachment: Screenshot: Experimental Add-on version

Comment 7

[Fred Wenzel [:wenzel]]

By the way: The patch contains two little png icons, so you want to use `git apply` to apply the patch.

Comment 8

[Wil Clouser [:clouserw]]

omg

That said, there are no images in the patch.  Did you --binary it?

Comment 9

[Fred Wenzel [:wenzel]]

Attachment: Patch, rev. 2

I forgot the --binary flag, thanks!

Comment 10

[Wil Clouser [:clouserw]]

Comment on attachment 380277 [details] [diff] [review]
Patch, rev. 2

This touches a lot of code so it has the potential to break stuff.  It WFM in my tests though, so I'll r+.  The page looks good.

Comment 11

[Fred Wenzel [:wenzel]]

r26542. Agreed, let's hope it didn't break anything more horribly than it was broken before. I made sure though that the install buttons still look reasonable in other places, after I removed the hideous version history hack from it.

Comment 12

[Stephen Donner [:stephend] Not actively reading bugmail]

The above URL has a self-linking breadcrumb :-(

Comment 13

[Fred Wenzel [:wenzel]]

Where else would the last one point?

Comment 14

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #13)
> Where else would the last one point?

Nowhere -- it's redundant.

Comment 15

[Fred Wenzel [:wenzel]]

Removed in r26548. NB: The string it used ("version history with change logs") was present on the old page and is now gone from the page.

Comment 16

[Stephen Donner [:stephend] Not actively reading bugmail]

Thanks, Fred -- this makes the page consistent with the other places we're using the breadcrumb.

Verified FIXED

Comment 18

[Stephen Donner [:stephend] Not actively reading bugmail]

removing "push-needed" from 105 AMO 5.0.6 bugs; filter on "I hate stephend!"