494892 - Clicking delete button in standalone window closes all standalone windows

Status: RESOLVED WORKSFORME

(Thunderbird :: Message Reader UI, defect)

Description

[Eric Shepherd [:sheppy]]

If you have "close window on delete" enabled, clicking the delete button in a standalone message window closes all currently open standalone windows instead of just the one you're deleting.

Comment 1

[Eric Shepherd [:sheppy]]

Only the message you're trying to delete gets deleted though, fwiw. Not sure what's causing all the open message windows to close though; window.close() is only getting called once as far as I can tell.

Comment 2

[Munroe]

I am using the July31st build of TB3 pre beta 4 (nightly) on a PPC Mac OS 10.4 and I am not seeing this behavior.  With "close window on delete" selected when I delete a message (in either a standalone window or tab) the window doesn't close, it just loads the next message.

Comment 3

[Magnus Melin [:mkmelin]]

Yeah, that's bug 498141.

Comment 4

[Andrew Sutherland [:asuth] (he/him)]

I think this bug is no longer relevant given that we regressed close-window-on-delete out of existence as tracked by bug 498141.  I will add a note to that bug that we should make sure it has a unit test that verifies that it doesn't get overzealous about closing things.

Comment 5

[Magnus Melin [:mkmelin]]

Reopening, bug 498141 was certainly fixable without fixing this one. The new patch there will fix this one too though.

Comment 6

[Rain [:rain1] (inactive)]

We've been able to avoid this bug from happening again in bug 498141. We've also added a test for this there.