494973 - Should remove installListener

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Hiroyuki Ikezoe (:hiro)]

Attachment: Proposed patch

This patch fixes the following warnings and memory leaks at exit of Fennec.

WARNING: Textrun cache not empty!: 'mCache.Count() == 0', file /home/zoe/hg/mozilla-central/gfx/thebes/src/gfxTextRunWordCache.cpp, line 85
Assertion failed at /home/zoe/hg/mozilla-central/gfx/cairo/cairo/src/cairo-hash.c:198: hash_table->live_entries == 0
3388
nsStringStats
 => mAllocCount:          11463
 => mReallocCount:         1736
 => mFreeCount:           10378  --  LEAKED 1085 !!!
 => mShareCount:          13400
 => mAdoptCount:           1076
 => mAdoptFreeCount:       1074  --  LEAKED 2 !!!

Moreover, as far as I can confirm, this patch also fixes bug 494721.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

http://hg.mozilla.org/mobile-browser/rev/627870ff78ab

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

If this also fixes bug 494721, we can close it too

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 379766 [details] [diff] [review]
Proposed patch 

I just changed "destroy" method to "uninit", which matches what Firefox browser.js does.

Comment 4

[Hiroyuki Ikezoe (:hiro)]

Thank you, Mark. I had no good idea about the method name. "uninit" looks reasonable.

I am now confirming bug 49721 is fixed or not.

Comment 5

[Hiroyuki Ikezoe (:hiro)]

(In reply to comment #4)
 
> I am now confirming bug 49721 is fixed or not.

Oops! I meant bug 494721.