Closed Bug 495012 Opened 15 years ago Closed 15 years ago

Sort and update mailnews/makefiles.sh

Categories

(MailNews Core :: Build Config, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b3

People

(Reporter: philor, Assigned: philor)

Details

Attachments

(1 file)

Attached patch FixSplinter Review
Seeing an oddly-timed makefile creation fly by in build output made me look at what was missing from mailnews/makefiles.sh, but between the way that if there's any order to it at all, that order isn't obvious, and that the hypothetical order isn't obvious to people manually adding new makefiles, it's a pain to check. After probably too long trying to find some combination of find and sort that would produce a portable ordering that also was obvious to someone manually adding, I settled on |find -s mailnews -name Makefile.in | sed "s/\.in$//"|, and if someone wants to recreate it without a Mac, they can jolly well install FreeBSD :) (Well, actually, install FreeBSD and tell me whether or not it produces the same output as the Mac find -s.)

From what I remember, the diff is tests, mapi, and some gloda subdirs. I manually removed extensions/palmsync since it's a dead extension walking, and extensions/dsn because it's both unused and unusable.
Attachment #379814 - Flags: review?(bugzilla)
Attachment #379814 - Attachment is patch: true
Attachment #379814 - Attachment mime type: application/octet-stream → text/plain
(In reply to comment #0)
> extensions/dsn because it's both unused and unusable.

Does that mean it should be removed? If so, can you file a followup on that?
Meh. Removed, fixed, or turned into an extension - bug 93085 is still open.
Attachment #379814 - Flags: review?(bugzilla) → review+
http://build.mozillamessaging.com/mercurial/comm-central/rev/e05622a88347
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.0b3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: